Re: [Qemu-devel] [Qemu-block] [PATCH v2 03/11] block: Mark fd handlers as "protocol"

[Fam Zheng <famz@redhat.com>]

On Thu, 08/27 14:53, Stefan Hajnoczi wrote:
> On Wed, Jul 29, 2015 at 12:42:06PM +0800, Fam Zheng wrote:
> > diff --git a/include/block/aio.h b/include/block/aio.h
> > index bd1d44b..d02ddfa 100644
> > --- a/include/block/aio.h
> > +++ b/include/block/aio.h
> > @@ -273,6 +273,7 @@ bool aio_pending(AioContext *ctx);
> >  bool aio_dispatch(AioContext *ctx);
> >  
> >  #define AIO_CLIENT_UNSPECIFIED    (1 << 0)
> > +#define AIO_CLIENT_PROTOCOL       (1 << 1)
> 
> The semantics need to be documented here, not just in the commit
> description.
> 
> AIO_CLIENT_BLOCK_DRIVER or AIO_CLIENT_BLOCK_PROTOCOL seems like a
> clearer name to me since "protocol" just by itself could mean many
> things.

OK, renaming to AIO_CLIENT_BLOCK_DRIVER.

Thanks,
Fam