From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings Date: Mon, 7 Sep 2015 19:05:16 +0100 Message-ID: <20150907180516.GC18079@leverpostej> References: <1437670365-20704-1-git-send-email-mark.rutland@arm.com> <1437670365-20704-3-git-send-email-mark.rutland@arm.com> <55B5E8C1.4030707@arm.com> <55EA1C3F.1030300@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <55EA1C3F.1030300-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org> Content-Language: en-US Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: David Daney Cc: Marc Zyngier , "tirumalesh.chalamarla-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org" , "Richter, Robert" , "Chintakuntla, Radha" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , Will Deacon , Robin Murphy , Lorenzo Pieralisi , "arnd-r2nGTMty4D4@public.gmane.org" , "treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org" , "majun258-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , "thunder.leizhen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , "laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org" List-Id: iommu@lists.linux-foundation.org On Fri, Sep 04, 2015 at 11:33:35PM +0100, David Daney wrote: > Hi Mark, Hi David, > I now have a prototype implementation for irq-gic-v3-its.c that is using > this binding on Cavium's ThunderX platform. > > Q: Have you guys had any more thoughts on this that might require > changing the binding? Having discussed this with Stuart and others at Linux Plumbers, I think that the binding is sufficient, and unlikely to change greatly unless there is a strong objection (Stuart, please correct me if I am wrong). Per Marc's comments there are probably some edge cases and/or wording details to sort out, but I think the common/simple case is sorted. I'll send a v2 once those have been settled. > If not, I will be sending out my patches for your consideration. Please do! > Thanks, > David Daney > > On 07/27/2015 01:16 AM, Marc Zyngier wrote: > > On 23/07/15 17:52, Mark Rutland wrote: > >> Currently msi-parent is used by a few bindings to describe the > >> relationship between a PCI root complex and a single MSI controller, but > >> this property does not have a generic binding document. > >> > >> Additionally, msi-parent is insufficient to describe more complex > >> relationships between MSI controllers and devices under a root complex, > >> where devices may be able to target multiple MSI controllers, or where > >> MSI controllers use (non-probeable) sideband information to distinguish > >> devices. > >> > >> This patch adds a generic binding for mapping PCI devices to MSI > >> controllers. This document covers msi-parent, and a new msi-map property > >> (specific to PCI*) which may be used to map devices (identified by their > >> Requester ID) to sideband data for each MSI controller that they may > >> target. > >> > >> Signed-off-by: Mark Rutland > > Acked-by: David Daney Thanks! Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.rutland@arm.com (Mark Rutland) Date: Mon, 7 Sep 2015 19:05:16 +0100 Subject: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings In-Reply-To: <55EA1C3F.1030300@caviumnetworks.com> References: <1437670365-20704-1-git-send-email-mark.rutland@arm.com> <1437670365-20704-3-git-send-email-mark.rutland@arm.com> <55B5E8C1.4030707@arm.com> <55EA1C3F.1030300@caviumnetworks.com> Message-ID: <20150907180516.GC18079@leverpostej> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, Sep 04, 2015 at 11:33:35PM +0100, David Daney wrote: > Hi Mark, Hi David, > I now have a prototype implementation for irq-gic-v3-its.c that is using > this binding on Cavium's ThunderX platform. > > Q: Have you guys had any more thoughts on this that might require > changing the binding? Having discussed this with Stuart and others at Linux Plumbers, I think that the binding is sufficient, and unlikely to change greatly unless there is a strong objection (Stuart, please correct me if I am wrong). Per Marc's comments there are probably some edge cases and/or wording details to sort out, but I think the common/simple case is sorted. I'll send a v2 once those have been settled. > If not, I will be sending out my patches for your consideration. Please do! > Thanks, > David Daney > > On 07/27/2015 01:16 AM, Marc Zyngier wrote: > > On 23/07/15 17:52, Mark Rutland wrote: > >> Currently msi-parent is used by a few bindings to describe the > >> relationship between a PCI root complex and a single MSI controller, but > >> this property does not have a generic binding document. > >> > >> Additionally, msi-parent is insufficient to describe more complex > >> relationships between MSI controllers and devices under a root complex, > >> where devices may be able to target multiple MSI controllers, or where > >> MSI controllers use (non-probeable) sideband information to distinguish > >> devices. > >> > >> This patch adds a generic binding for mapping PCI devices to MSI > >> controllers. This document covers msi-parent, and a new msi-map property > >> (specific to PCI*) which may be used to map devices (identified by their > >> Requester ID) to sideband data for each MSI controller that they may > >> target. > >> > >> Signed-off-by: Mark Rutland > > Acked-by: David Daney Thanks! Mark. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751994AbbIGSFb (ORCPT ); Mon, 7 Sep 2015 14:05:31 -0400 Received: from foss.arm.com ([217.140.101.70]:52106 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751050AbbIGSF3 (ORCPT ); Mon, 7 Sep 2015 14:05:29 -0400 Date: Mon, 7 Sep 2015 19:05:16 +0100 From: Mark Rutland To: David Daney Cc: Marc Zyngier , "tirumalesh.chalamarla@caviumnetworks.com" , "Richter, Robert" , "Chintakuntla, Radha" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "linux-arm-kernel@lists.infradead.org" , Will Deacon , Robin Murphy , Lorenzo Pieralisi , "arnd@arndb.de" , "treding@nvidia.com" , "majun258@huawei.com" , "thunder.leizhen@huawei.com" , "laurent.pinchart@ideasonboard.com" , stuart.yoder@freescale.com Subject: Re: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings Message-ID: <20150907180516.GC18079@leverpostej> References: <1437670365-20704-1-git-send-email-mark.rutland@arm.com> <1437670365-20704-3-git-send-email-mark.rutland@arm.com> <55B5E8C1.4030707@arm.com> <55EA1C3F.1030300@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55EA1C3F.1030300@caviumnetworks.com> Thread-Topic: [PATCH 2/3] Docs: dt: Add PCI MSI map bindings Accept-Language: en-GB, en-US Content-Language: en-US acceptlanguage: en-GB, en-US User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 04, 2015 at 11:33:35PM +0100, David Daney wrote: > Hi Mark, Hi David, > I now have a prototype implementation for irq-gic-v3-its.c that is using > this binding on Cavium's ThunderX platform. > > Q: Have you guys had any more thoughts on this that might require > changing the binding? Having discussed this with Stuart and others at Linux Plumbers, I think that the binding is sufficient, and unlikely to change greatly unless there is a strong objection (Stuart, please correct me if I am wrong). Per Marc's comments there are probably some edge cases and/or wording details to sort out, but I think the common/simple case is sorted. I'll send a v2 once those have been settled. > If not, I will be sending out my patches for your consideration. Please do! > Thanks, > David Daney > > On 07/27/2015 01:16 AM, Marc Zyngier wrote: > > On 23/07/15 17:52, Mark Rutland wrote: > >> Currently msi-parent is used by a few bindings to describe the > >> relationship between a PCI root complex and a single MSI controller, but > >> this property does not have a generic binding document. > >> > >> Additionally, msi-parent is insufficient to describe more complex > >> relationships between MSI controllers and devices under a root complex, > >> where devices may be able to target multiple MSI controllers, or where > >> MSI controllers use (non-probeable) sideband information to distinguish > >> devices. > >> > >> This patch adds a generic binding for mapping PCI devices to MSI > >> controllers. This document covers msi-parent, and a new msi-map property > >> (specific to PCI*) which may be used to map devices (identified by their > >> Requester ID) to sideband data for each MSI controller that they may > >> target. > >> > >> Signed-off-by: Mark Rutland > > Acked-by: David Daney Thanks! Mark.