From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753200AbbIHHdY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 8 Sep 2015 03:33:24 -0400
Received: from mail-wi0-f180.google.com ([209.85.212.180]:36320 "EHLO
	mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751548AbbIHHdW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 8 Sep 2015 03:33:22 -0400
Date: Tue, 8 Sep 2015 09:33:18 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
        "K. Y. Srinivasan" <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>, x86@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hyperv: fix build if KEXEC not enabled
Message-ID: <20150908073318.GA7269@gmail.com>
References: <20150907102222.27d0477b@urahara>
 <87egi9bclm.fsf@vitty.brq.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87egi9bclm.fsf@vitty.brq.redhat.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Vitaly Kuznetsov <vkuznets@redhat.com> wrote:

> Stephen Hemminger <stephen@networkplumber.org> writes:
> 
> > Fixes regression 4.3 mergw window in my config 
> > where hyperv is enable but CONFIG_KEXEC not enabled.
> >
> > arch/x86/kernel/cpu/mshyperv.c:112: undefined reference to `native_machine_crash_shutdown'
> >
> > Introduced by:
> >    commit b4370df2b1f5158de028e167974263c5757b34a6
> >    Author: Vitaly Kuznetsov <vkuznets@redhat.com>
> >    Date:   Sat Aug 1 16:08:09 2015 -0700
> >
> >        Drivers: hv: vmbus: add special crash handler
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > --- a/arch/x86/kernel/cpu/mshyperv.c	2015-09-07 10:11:24.994885115 -0700
> > +++ b/arch/x86/kernel/cpu/mshyperv.c	2015-09-07 10:14:20.995698615 -0700
> > @@ -109,7 +109,9 @@ static void hv_machine_crash_shutdown(st
> >  {
> >  	if (hv_crash_handler)
> >  		hv_crash_handler(regs);
> > +#ifdef CONFIG_KEXEC
> >  	native_machine_crash_shutdown(regs);
> > +#endif
> >  }
> 
> Greg in particular was against #ifdefs in C code and I sent the
> following patch to fix the issue:
> 
> https://lkml.org/lkml/2015/8/11/417

Note that this is still somewhat buggy, the whole hv_machine_crash_shutdown() 
should be conditional - like in kvmclock.c.

Thanks,

	Ingo