Re: [Qemu-devel] [PATCH 2/4] monitor: remove target-specific code from monitor.c

[Luiz Capitulino <lcapitulino@redhat.com>]

On Tue, 8 Sep 2015 09:04:56 -0400 (EDT)
Paolo Bonzini <pbonzini@redhat.com> wrote:

> 
> > > This should be added in patch 4, not now.
> > > 
> > > > +const MonitorDef *target_monitor_defs(void) __attribute__((weak));
> > > > +
> > > > +const MonitorDef *target_monitor_defs(void)
> > > > +{
> > > > +    return NULL;
> > > > +}
> > > 
> > > Weak symbols do not work on all platforms.  Luckily, making libqemustub
> > > a static library gets exactly the same result without the need for weak
> > > symbols: the definition from the QEMU object files will hide the stub.
> > > 
> > > You just need to remove __attribute__((weak)), and it should just work.
> > > 
> > > Otherwise, the patches look good to me.  Luiz, do you have time to post
> > > a pull request for v4, or do you want to pass HMP maintainership as well
> > > to someone else?
> > 
> > It would be great to pass it to someone else.
> 
> I can take the next version of these patches then.  

Thanks a lot! These are the patches I have pending for review:

- [PATCH qemu 0/2] monitor/ppc: Print correct SPRs
- [PATCH] trace-events: Add hmp completion
- [PATCH v3 0/4] Move target- and device specific code from monitor

> However, please make that
> someone else also be someone other than me. :-)

Well, we've always been short on maintainers...