From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35816)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZZKEt-0004nt-RQ
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 10:51:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZZKEr-0004xQ-4D
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 10:51:15 -0400
Received: from mail-bn1bon0072.outbound.protection.outlook.com
	([157.56.111.72]:6704
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZZKEn-0004wt-58
	for qemu-devel@nongnu.org; Tue, 08 Sep 2015 10:51:13 -0400
Date: Tue, 8 Sep 2015 16:51:02 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150908145102.GG12618@toto>
References: <1441719672-25296-1-git-send-email-nathan@nathanrossi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1441719672-25296-1-git-send-email-nathan@nathanrossi.com>
Subject: Re: [Qemu-devel] [PATCH] arm: xlnx-zynqmp: Fix up GIC region size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Rossi <nathan@nathanrossi.com>
Cc: "Edgar E . Iglesias" <edgar.iglesias@gmail.com>, crosthwaite.peter@gmail.com, alistair.francis@xilinx.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

On Tue, Sep 08, 2015 at 11:41:12PM +1000, Nathan Rossi wrote:
> The GIC in ZynqMP cover a 64K address space, however the actual
> registers are decoded within a 4K address space and mirrored at the 4K
> boundaries. This change fixes the defined size for these regions as it
> was set to 0x4000/16K incorrectly.
> 
> Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>

Adding Alistair, Crosthwaite and Maydell.

Thanks Nathan!
Edgar


> ---
>  include/hw/arm/xlnx-zynqmp.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp.h
> index 6ccb57b..23b8453 100644
> --- a/include/hw/arm/xlnx-zynqmp.h
> +++ b/include/hw/arm/xlnx-zynqmp.h
> @@ -44,7 +44,7 @@
>   * number of memory region aliases.
>   */
>  
> -#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x4000
> +#define XLNX_ZYNQMP_GIC_REGION_SIZE 0x1000
>  #define XLNX_ZYNQMP_GIC_ALIASES     (0x10000 / XLNX_ZYNQMP_GIC_REGION_SIZE - 1)
>  
>  typedef struct XlnxZynqMPState {
> -- 
> 2.5.1
>