All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin O'Connor <kevin@koconnor.net>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: "Marc Marí" <markmb@redhat.com>,
	"Stefan Hajnoczi" <stefanha@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Drew <drjones@redhat.com>, Laszlo <lersek@redhat.com>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Rob Herring" <rob.herring@linaro.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Alexander Graf" <agraf@suse.de>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2] QEMU fw_cfg DMA interface documentation
Date: Tue, 8 Sep 2015 12:46:08 -0400	[thread overview]
Message-ID: <20150908164608.GA9169@morn.lan> (raw)
In-Reply-To: <1441624109.27149.18.camel@redhat.com>

On Mon, Sep 07, 2015 at 01:08:29PM +0200, Gerd Hoffmann wrote:
> > It's just simplicity. If you want to read a few times from the same
> > field (like in ACPI tables, read the data size and then the data), you
> > need a way to enable and disable the selector and manage the current
> > offset for that entry. This is already provided with the "old"
> > interface.
> 
> Could be handled with a 'select' control bit.  Only when set select
> entry and reset offset to zero.

I think two features would help "round off" the new fw_cfg DMA
proposal: add a select bit as you describe (that uses the 16 most
significant bits of the "control" field for the "select entry" when
the bit is set), and define a static signature (eg, "QEMU CFG") when
reading the 64bit MMIO dma register.

Both are optional features that don't change the fundamental
interface; I was thinking of sending them as two patches on top of
Marc's next version of his patch series (if no one else gets to it
first).

-Kevin

  parent reply	other threads:[~2015-09-08 16:46 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31  9:08 QEMU fw_cfg DMA interface Marc Marí
2015-08-31  9:08 ` [Qemu-devel] " Marc Marí
2015-08-31  9:08 ` Marc Marí
2015-08-31  9:10 ` [Qemu-devel] [PATCH v2 0/5] " Marc Marí
2015-08-31  9:10   ` [Qemu-devel] [PATCH v2 1/5] fw_cfg: document fw_cfg_modify_iXX() update functions Marc Marí
2015-09-01 17:33     ` Peter Maydell
2015-09-01 17:45       ` Gabriel L. Somlo
2015-09-01 18:45         ` Peter Maydell
2015-09-01 19:13           ` Gabriel L. Somlo
2015-09-01 20:10             ` Peter Maydell
2015-09-01 20:27               ` Gabriel L. Somlo
2015-09-01 20:30                 ` Peter Maydell
2015-09-02  8:08               ` Gerd Hoffmann
2015-09-02  9:21                 ` Laszlo Ersek
2015-08-31  9:10   ` [Qemu-devel] [PATCH v2 2/5] fw_cfg DMA interface documentation Marc Marí
2015-08-31 15:36     ` Kevin O'Connor
2015-09-01 17:47     ` Peter Maydell
2015-09-01 17:56       ` Peter Maydell
2015-08-31  9:10   ` [Qemu-devel] [PATCH v2 3/5] Implement fw_cfg DMA interface Marc Marí
2015-08-31 15:58     ` Kevin O'Connor
2015-09-01 18:35     ` Peter Maydell
2015-08-31  9:10   ` [Qemu-devel] [PATCH v2 4/5] Enable fw_cfg DMA interface for ARM Marc Marí
2015-09-01 18:02     ` Peter Maydell
2015-08-31  9:10   ` [Qemu-devel] [PATCH v2 5/5] Enable fw_cfg DMA interface for x86 Marc Marí
     [not found] ` <1441012133-8154-1-git-send-email-markmb-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-08-31  9:11   ` [PATCH v2] QEMU fw_cfg DMA interface documentation Marc Marí
2015-08-31  9:11     ` Marc Marí
2015-09-02  8:20     ` Stefan Hajnoczi
     [not found]       ` <CAJSP0QXgiMo0ahzRQ=2iMXVmiO+R27Re17c966LX1T_Q=Rdgow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-09-02  8:33         ` Marc Marí
2015-09-02  8:33           ` Marc Marí
2015-09-07 11:08           ` Gerd Hoffmann
     [not found]             ` <1441624109.27149.18.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-09-07 11:25               ` Laszlo Ersek
2015-09-07 11:25                 ` Laszlo Ersek
2015-09-08 16:46             ` Kevin O'Connor [this message]
2015-09-10 14:21               ` Marc Marí

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150908164608.GA9169@morn.lan \
    --to=kevin@koconnor.net \
    --cc=agraf@suse.de \
    --cc=arnd@arndb.de \
    --cc=devicetree@vger.kernel.org \
    --cc=drjones@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=lersek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=markmb@redhat.com \
    --cc=rob.herring@linaro.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.