From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, HPDD-discuss@ml01.01.org,
devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] staging: lustre: lov: remove always false condition
Date: Tue, 8 Sep 2015 23:12:50 +0530 [thread overview]
Message-ID: <20150908174250.GA32706@sudip-pc> (raw)
In-Reply-To: <1441731189.17219.1.camel@perches.com>
On Tue, Sep 08, 2015 at 09:53:09AM -0700, Joe Perches wrote:
> On Tue, 2015-09-08 at 21:53 +0530, Sudip Mukherjee wrote:
> > if (qctl->qc_valid == QC_OSTIDX) {
> > - if (qctl->qc_idx < 0 || count <= qctl->qc_idx)
> > + if (count <= qctl->qc_idx)
>
> Perhaps this test would be clearer reversed too
>
> if (qctl->qc_idx >= count)
There are more such comparison in that file, like:
1) if (ost_idx >= lov->desc.ld_tgt_count)
2) if (index >= lov->lov_tgt_size)
and some more.
And if I include it in this patch then it will become separate change.
I will better send a separate patch for this.
Regards
Sudip
prev parent reply other threads:[~2015-09-08 17:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 16:23 [PATCH 1/2] staging: lustre: lov: fix dereference of ERR_PTR Sudip Mukherjee
2015-09-08 16:23 ` [PATCH 2/2] staging: lustre: lov: remove always false condition Sudip Mukherjee
2015-09-08 16:53 ` Joe Perches
2015-09-08 17:42 ` Sudip Mukherjee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908174250.GA32706@sudip-pc \
--to=sudipm.mukherjee@gmail.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.