From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Daniel Wagner <wagi@monom.org>,
linux-kernel@vger.kernel.org, mingo@kernel.org,
jiangshanlai@gmail.com, dipankar@in.ibm.com,
akpm@linux-foundation.org, mathieu.desnoyers@efficios.com,
josh@joshtriplett.org, tglx@linutronix.de, peterz@infradead.org,
rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com,
dvhart@linux.intel.com, fweisbec@gmail.com,
bobby.prani@gmail.com
Subject: Re: [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU checks
Date: Tue, 8 Sep 2015 16:32:51 -0700 [thread overview]
Message-ID: <20150908233251.GC4029@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150907125247.GA862@redhat.com>
On Mon, Sep 07, 2015 at 02:52:47PM +0200, Oleg Nesterov wrote:
> On 09/07, Daniel Wagner wrote:
> >
> > On 08/29/2015 05:35 AM, Paul E. McKenney wrote:
> > > +extern bool __rcu_sync_is_idle(struct rcu_sync *);
> > > +
> > > /**
> > > * rcu_sync_is_idle() - Are readers permitted to use their fastpaths?
> > > * @rsp: Pointer to rcu_sync structure to use for synchronization
> > > @@ -50,7 +52,11 @@ struct rcu_sync {
> > > */
> > > static inline bool rcu_sync_is_idle(struct rcu_sync *rsp)
> > > {
> > > +#ifdef CONFIG_PROVE_RCU
> > > + return __rcu_sync_is_idle(rss);
> >
> > s/rss/rsp?
>
> Hmm, yes.
>
> Paul, it seems that you renamed "rss" to "rsp" globally (I didn't even
> notice this change), but forgot about this one ;)
>
> Should I send the patch or will you fix this yourself?
I did fix it in -rcu, and a few other breakages as well. Most of them
self-inflicted, as usual. However, I am holding off on this series in
order to get it a bit more pre-merge testing. I expect to push this
in v4.4.
Thanx, Paul
next prev parent reply other threads:[~2015-09-08 23:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-29 3:26 [PATCH RFC tip/core/rcu 0/9] Add rcu_sync and implement percpu_rwsem in terms of it Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 1/9] rcu: Create rcu_sync infrastructure Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 2/9] rcu_sync: Simplify rcu_sync using new rcu_sync_ops structure Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 3/9] rcu_sync: Add CONFIG_PROVE_RCU checks Paul E. McKenney
2015-09-07 9:02 ` Daniel Wagner
2015-09-07 12:52 ` Oleg Nesterov
2015-09-08 23:32 ` Paul E. McKenney [this message]
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 4/9] rcu_sync: Introduce rcu_sync_dtor() Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 5/9] locking/percpu-rwsem: Make percpu_free_rwsem() after kzalloc() safe Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 6/9] locking/percpu-rwsem: Make use of the rcu_sync infrastructure Paul E. McKenney
2015-08-29 3:35 ` [PATCH RFC tip/core/rcu 7/9] locking/percpu-rwsem: Fix the comments outdated by rcu_sync Paul E. McKenney
2015-08-29 3:36 ` [PATCH RFC tip/core/rcu 8/9] locking/percpu-rwsem: Clean up the lockdep annotations in percpu_down_read() Paul E. McKenney
2015-08-29 3:36 ` [PATCH RFC tip/core/rcu 9/9] rcu: Change _wait_rcu_gp() to work around GCC bug 67055 Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150908233251.GC4029@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bobby.prani@gmail.com \
--cc=dhowells@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=dvhart@linux.intel.com \
--cc=edumazet@google.com \
--cc=fweisbec@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=wagi@monom.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.