All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: Chaehyun Lim <chaehyun.lim@gmail.com>
Cc: gregkh@linuxfoundation.org, rachel.kim@atmel.com,
	devel@driverdev.osuosl.org, chris.park@atmel.com,
	linux-wireless@vger.kernel.org, johnny.kim@atmel.com
Subject: Re: [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC
Date: Wed, 9 Sep 2015 12:07:17 +0530	[thread overview]
Message-ID: <20150909063717.GA7003@sudip-pc> (raw)
In-Reply-To: <1441640199-1507-4-git-send-email-chaehyun.lim@gmail.com>

On Tue, Sep 08, 2015 at 12:36:38AM +0900, Chaehyun Lim wrote:
> This patch use kmalloc with GFP_ATOMIC instead of WILC_MALLOC.
> It is inside the spin lock region.
> 
> Signed-off-by: Chaehyun Lim <chaehyun.lim@gmail.com>
> ---
Its not related to your patch, but while seeing your patch I thought of
checking how WILC_NULLCHECK is working. Well, WILC_NULLCHECK is simple,
its just checking for NULL and calling WILC_ERRORREPORT.
WILC_ERRORREPORT is also simple, it is printing the error and then
goto ERRORHANDLER;
Ok, so now there are total 3 ERRORHANDLER label, one in
wilc_errorsupport.h, there this label is the part of WILC_CATCH macro,
and 2 more ERRORHANDLER in coreconfigurator.c. So it jumps to which
ERRORHANDLER ???

regards
sudip

  parent reply	other threads:[~2015-09-09  6:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-07 15:36 [PATCH 1/5] staging: wilc1000: linux_wlan.c: use kzalloc instead of WILC_MALLOC Chaehyun Lim
2015-09-07 15:36 ` [PATCH 2/5] staging: wilc1000: linux_wlan.c: add kzalloc error check Chaehyun Lim
2015-09-07 15:36 ` [PATCH 3/5] staging: wilc1000: remove commented codes Chaehyun Lim
2015-09-07 15:36 ` [PATCH 4/5] staging: wilc1000: wilc_msgqueue.c: use kmalloc with GFP_ATOMIC Chaehyun Lim
2015-09-08  2:23   ` Tony Cho
2015-09-08  4:48     ` Greg KH
2015-09-09  6:37   ` Sudip Mukherjee [this message]
2015-09-07 15:36 ` [PATCH 5/5] staging: wilc1000: host_interface.c: fix build warning Chaehyun Lim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909063717.GA7003@sudip-pc \
    --to=sudipm.mukherjee@gmail.com \
    --cc=chaehyun.lim@gmail.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johnny.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.