From: Stephen Hemminger <stephen@networkplumber.org>
To: Matthias Tafelmeier <matthias.tafelmeier@gmx.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hagen@jauu.net" <hagen@jauu.net>,
"shemminger@osdl.org" <shemminger@osdl.org>,
"fw@strlen.de" <fw@strlen.de>,
"edumazet@google.com" <edumazet@google.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Subject: Re: [PATCH v6 02/10] ss: created formatters for json and hr
Date: Wed, 9 Sep 2015 14:30:49 -0700 [thread overview]
Message-ID: <20150909143049.0aa08d37@urahara> (raw)
In-Reply-To: <4b7ff1016053461a80465ce8138e12a2@HQ1WP-EXMB11.corp.brocade.com>
On Wed, 9 Sep 2015 19:43:13 +0000
Matthias Tafelmeier <matthias.tafelmeier@gmx.net> wrote:
> +#define STATIC_ASSERT(COND, MSG) \
> +{ \
> + char STATIC_ASSERT##MSG[(COND) ? 1 : -1]; \
> + (void)STATIC_ASSERT##MSG[0]; \
> +}
If you are going to introduce this, please use same convention
as Linux kernel. ie. BUILD_BUG_ON()
Your code looks like it came out of some other project.
next prev parent reply other threads:[~2015-09-09 21:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 19:43 iproute2 v6: full ss json support and general output simplification Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 01/10] ss: rooted out ss type declarations for output formatters Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 02/10] ss: created formatters for json and hr Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 03/10] ss: removed obsolet fmt functions Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 04/10] ss: prepare timer for output handler usage Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 05/10] ss: replaced old output with new generic output mechanisms Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 06/10] ss: renaming and export of current_filter Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 07/10] ss: symmetrical subhandler output extension example Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 08/10] ss: symmetrical formatter " Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 09/10] ss: fixed free on local array for valid json output Matthias Tafelmeier
2015-09-09 19:43 ` [PATCH v6 10/10] ss: activate json_writer excluded logic Matthias Tafelmeier
[not found] ` <4b7ff1016053461a80465ce8138e12a2@HQ1WP-EXMB11.corp.brocade.com>
2015-09-09 21:30 ` Stephen Hemminger [this message]
2015-09-09 22:00 ` [PATCH v6 02/10] ss: created formatters for json and hr Matthias Tafelmeier
[not found] ` <cf829f8ac6ea466eb9bb693350dd3291@HQ1WP-EXMB11.corp.brocade.com>
2015-09-09 22:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909143049.0aa08d37@urahara \
--to=stephen@networkplumber.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hagen@jauu.net \
--cc=matthias.tafelmeier@gmx.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.