From: Alban <albeu@free.fr>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alban <albeu@free.fr>,
linux-mips@linux-mips.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Ralf Baechle <ralf@linux-mips.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] MIPS: ath79: Add USB support on the TL-WR1043ND
Date: Wed, 9 Sep 2015 16:14:59 +0200 [thread overview]
Message-ID: <20150909161459.30cf580f@avionic-0020> (raw)
In-Reply-To: <3589971.cbF7muh57v@wuerfel>
On Mon, 07 Sep 2015 15:20:42 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday 01 September 2015 17:23:10 Alban Bedel wrote:
> >
> > this serie add a driver for the USB phy on the ATH79 SoCs and enable the
> > USB port on the TL-WR1043ND. The phy controller is really trivial as it
> > only use reset lines.
> >
>
> Is this a common thing to have? If other PHY devices are like this, we
> could instead add a simple generic PHY driver that just asserts all
> its reset lines in the order as provided, rather than making this a
> hardware specific driver that ends up getting copied several times.
I don't know how common it is. However I agree that a simple driver that
can start a clock and toggle a few GPIO and/or reset would make sense.
However in the case of the ATH79 SoC some models have a reset line that
is misused to force the PHY in sleep mode. Sadly this extra reset must
be asserted for the PHY to work, so it wouldn't fit in such a generic
design.
Still we could have such a generic driver and let the ATH79 driver
build on top of it. Honestly that's what I wanted to do, but getting
generic drivers with DT support accepted is not easy. That's why I went
with this driver, it is technically inferior but much easier to get
considered for merging.
Alban
next prev parent reply other threads:[~2015-09-09 14:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 15:23 [PATCH 0/4] MIPS: ath79: Add USB support on the TL-WR1043ND Alban Bedel
2015-09-01 15:23 ` Alban Bedel
2015-09-01 15:23 ` [PATCH 1/4] devicetree: Add bindings for the ATH79 USB phy Alban Bedel
2015-09-01 15:23 ` [PATCH 2/4] phy: Add a driver " Alban Bedel
2015-09-01 15:23 ` [PATCH 3/4] MIPS: ath79: Add the EHCI controller and USB phy to the AR9132 dtsi Alban Bedel
2015-09-01 16:59 ` Sergei Shtylyov
2015-09-01 16:59 ` Sergei Shtylyov
2015-09-01 15:23 ` [PATCH 4/4] MIPS: ath79: Enable the USB port on the TL-WR1043ND Alban Bedel
2015-09-07 13:20 ` [PATCH 0/4] MIPS: ath79: Add USB support " Arnd Bergmann
2015-09-09 14:14 ` Alban [this message]
2015-09-09 14:21 ` Arnd Bergmann
2015-09-29 11:10 ` Kishon Vijay Abraham I
2015-09-29 11:10 ` Kishon Vijay Abraham I
2015-09-29 11:10 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909161459.30cf580f@avionic-0020 \
--to=albeu@free.fr \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.