All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>,
	QEMU <qemu-devel@nongnu.org>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent
Date: Wed, 09 Sep 2015 12:36:08 -0500	[thread overview]
Message-ID: <20150909173608.3885.65691@loki> (raw)
In-Reply-To: <CAJ+F1CKVJyvwXbttDp89spj8pTZsQuqvC2Aw_cFFXmtGN4P+Wg@mail.gmail.com>

Quoting Marc-André Lureau (2015-08-27 06:36:43)
> On Thu, Aug 27, 2015 at 12:52 PM,  <marcandre.lureau@redhat.com> wrote:
> > +    success = success && status == 0 && g_strcmp0(virt_what, virt);
> 
> this is now:
> g_strcmp0(g_strstrip(virt_what), virt) == 0

Just to be sure, is this the change you intended?

diff --git a/tests/test-qga.c b/tests/test-qga.c
index 1fb58ec..ca4bcb5 100644
--- a/tests/test-qga.c
+++ b/tests/test-qga.c
@@ -634,7 +634,8 @@ static gboolean running_in_virt(const gchar *virt)
     success = g_spawn_command_line_sync("virt-what", &virt_what, NULL,
                                         &status, NULL);
 
-    success = success && status == 0 && g_strcmp0(virt_what, virt);
+    success = success && status == 0 &&
+        g_strcmp0(g_strstrip(virt_what), virt) == 0;
 
     g_free(virt_what);

> 
> -- 
> Marc-André Lureau
> 

  reply	other threads:[~2015-09-09 20:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-27 10:52 [Qemu-devel] [PATCH 1/2] qtest: add a few fd-level qmp helpers marcandre.lureau
2015-08-27 10:52 ` [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent marcandre.lureau
2015-08-27 11:36   ` Marc-André Lureau
2015-09-09 17:36     ` Michael Roth [this message]
2015-09-09 21:53   ` Michael Roth
2015-09-11 17:46     ` Marc-André Lureau
2015-09-09 20:05 ` [Qemu-devel] [PATCH 1/2] qtest: add a few fd-level qmp helpers Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150909173608.3885.65691@loki \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.