All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Cho <tony.cho@atmel.com>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
	johnny.kim@atmel.com, chris.park@atmel.com, rachel.kim@atmel.com,
	glen.lee@atmel.com, leo.kim@atmel.com, austin.shin@atmel.com,
	adel.noureldin@atmel.com, adham.abozaeid@atmel.com,
	Nicolas.FERRE@atmel.com
Subject: Re: [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h
Date: Wed, 9 Sep 2015 22:07:54 -0700	[thread overview]
Message-ID: <20150910050754.GA14718@kroah.com> (raw)
In-Reply-To: <55F0E619.5000808@atmel.com>

On Thu, Sep 10, 2015 at 11:08:25AM +0900, Tony Cho wrote:
> Hi Greg,
> 
> I want to make sure one thing before moving further. Are you saying
> the errorsupport.h file as the os wrapper remaining in the oswrapper.h
> file?  If not, can you let me know what you point out as remaining os
> wrapper in the oswrapper.h file?

I don't remember at this point in time, sorry, that was a few hundred
patches I reviewed ago, and 5 hours of meetings after that...

> If yes, I have been already replacing all of error values defined in
> the errorsupport.h file so that I send you the next patch when done.

That would be good to have.

I think my point was that you can't just move things from a .h file to
another .h file, clean up the os wrappers by removing them entirely,
like I did with the other wrapper functions for delays and other things.

thanks,

greg k-h

  reply	other threads:[~2015-09-10  5:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-09  7:08 [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper Tony Cho
2015-09-09  7:08 ` [PATCH 2/4] staging: wilc1000: delete wilc_memory.c and wilc_memory.h Tony Cho
2015-09-09  7:08 ` [PATCH 3/4] staging: wilc1000: delete wilc_oswrapper.h and wilc_platform.h Tony Cho
2015-09-09 18:19   ` Greg KH
2015-09-10  2:08     ` Tony Cho
2015-09-10  5:07       ` Greg KH [this message]
2015-09-09  7:08 ` [PATCH 4/4] staging: wilc1000: remove unused PLAT_RK3026_TCHIP Tony Cho
2015-09-09 18:17 ` [PATCH 1/4] staging: wilc1000: remove kmalloc wrapper Greg KH
2015-09-10  1:41   ` Tony Cho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910050754.GA14718@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Nicolas.FERRE@atmel.com \
    --cc=adel.noureldin@atmel.com \
    --cc=adham.abozaeid@atmel.com \
    --cc=austin.shin@atmel.com \
    --cc=chris.park@atmel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=glen.lee@atmel.com \
    --cc=johnny.kim@atmel.com \
    --cc=leo.kim@atmel.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rachel.kim@atmel.com \
    --cc=tony.cho@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.