From: Aaron Lu <aaron.lu@intel.com>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bastien Nocera <hadess@hadess.net>, Yu Chen <yu.c.chen@intel.com>
Subject: Re: New Surface 3 (atom x7) having problems with ACPI regions
Date: Thu, 10 Sep 2015 15:35:56 +0800 [thread overview]
Message-ID: <20150910073556.GA6863@aaronlu.sh.intel.com> (raw)
In-Reply-To: <55F0FD2A.7050900@intel.com>
On Thu, Sep 10, 2015 at 11:46:50AM +0800, Aaron Lu wrote:
> I'm not so sure of the below part:
> "
> The failure of executing the _STA control method will cause the device
> node not having the acpi_device structure created and then in the SPI
> ACPI enumerate function acpi_spi_add_device, it will not be created and
> used.
> "
With the above said, I wonder if the following patch which ignores the
error return of the _STA and set status to 0 makes any difference?
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c
index ec256352f423..418c8a7cec91 100644
--- a/drivers/acpi/scan.c
+++ b/drivers/acpi/scan.c
@@ -2293,7 +2293,7 @@ static int acpi_bus_type_and_status(acpi_handle handle, int *type,
*type = ACPI_BUS_TYPE_DEVICE;
status = acpi_bus_get_status_handle(handle, sta);
if (ACPI_FAILURE(status))
- return -ENODEV;
+ *sta = 0;
break;
case ACPI_TYPE_PROCESSOR:
*type = ACPI_BUS_TYPE_PROCESSOR;
next prev parent reply other threads:[~2015-09-10 7:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 13:51 New Surface 3 (atom x7) having problems with ACPI regions Benjamin Tissoires
2015-09-10 3:46 ` Aaron Lu
2015-09-10 7:35 ` Aaron Lu [this message]
2015-09-17 12:41 ` Bastien Nocera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910073556.GA6863@aaronlu.sh.intel.com \
--to=aaron.lu@intel.com \
--cc=benjamin.tissoires@gmail.com \
--cc=hadess@hadess.net \
--cc=linux-acpi@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.