From mboxrd@z Thu Jan 1 00:00:00 1970 From: Charles Keepax Subject: Re: [PATCH 1/2] ASoC: wm8960: correct the min gain value of some PGA Date: Thu, 10 Sep 2015 12:35:50 +0100 Message-ID: <20150910113549.GA29426@ck-lbox> References: <22ae1784eb84bf45b23bb7095b7dea8a116c0c2c.1441798038.git.zidan.wang@freescale.com> <20150909114954.GA30013@edi-sw-dsktp001.ad.cirrus.com> <20150910011529.GA13451@shlinux2> <20150910082420.GC3483@edi-sw-dsktp001.ad.cirrus.com> <20150910105821.GG20922@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx0b-001ae601.pphosted.com (mx0b-001ae601.pphosted.com [67.231.152.168]) by alsa0.perex.cz (Postfix) with ESMTP id 087FA2614D6 for ; Thu, 10 Sep 2015 13:58:47 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20150910105821.GG20922@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, Zidan Wang List-Id: alsa-devel@alsa-project.org On Thu, Sep 10, 2015 at 11:58:21AM +0100, Mark Brown wrote: > On Thu, Sep 10, 2015 at 09:24:20AM +0100, Charles Keepax wrote: > > On Thu, Sep 10, 2015 at 09:15:32AM +0800, Zidan Wang wrote: > > > > > > +static const DECLARE_TLV_DB_SCALE(adc_tlv, -9750, 50, 1); > > > > > +static const DECLARE_TLV_DB_SCALE(dac_tlv, -12750, 50, 1); > > > > I think the min register value will corresponding to the min gain. > > > So value 0 will also have a gain value, although it's for digital mute. > > > > Refer to wm8962 codec driver, beep gain range is -90db~-6db, step in 6db, > > > but it define the beep gain like below: > > > static const DECLARE_TLV_DB_SCALE(beep_tlv, -9600, 600, 1); > > > I might have to defer to Mark on this one then, if it is normal > > to just use an additional gain value for mute in this type of > > situation then it is ok with me. But it doesn't seem like that > > would be a sensible thing, as you are asking for -97.5dB but > > that is not what you are getting which doesn't seem like the > > nicest interface. > > The last value in the scale macro is a flag saying if the minimum value > is mute - if it's set to 1 userspace should know this is what's going > on. Ah sorry my bad, thanks. In that case: Acked-by: Charles Keepax Thanks, Charles