From: "Michael S. Tsirkin" <mst@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: cornelia.huck@de.ibm.com, den@openvz.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers
Date: Thu, 10 Sep 2015 12:32:58 +0300 [thread overview]
Message-ID: <20150910123113-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <55F14D23.6090906@redhat.com>
On Thu, Sep 10, 2015 at 11:28:03AM +0200, Paolo Bonzini wrote:
>
>
> On 10/09/2015 11:25, Michael S. Tsirkin wrote:
> > > It is needed because kvm headers include <asm/hyperv.h> and you don't
> > > want to pick the system version.
> >
> > I see. Makes sense. Then maybe don't bother with kvm.c either?
> > Keeps it consistent ...
>
> kvm.c keeps it consistent between target-i386/kvm.c and
> target-i386/cpu.h (which will include standard-headers/asm-x86/hyperv.h
> in Denis's patch).
>
> Paolo
Yes but kvm_para.h uses asm/hyperv.h
MAybe do the same everywhere?
Seems marginally prettier, but you decide, I'm not interested
in pushing this point.
--
MST
next prev parent reply other threads:[~2015-09-10 9:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 16:33 [Qemu-devel] [PATCH v2 0/2] update-linux-headers changes Paolo Bonzini
2015-09-09 16:34 ` [Qemu-devel] [PATCH v2 1/2] update Linux headers to 4.2 Paolo Bonzini
2015-09-10 7:31 ` Michael S. Tsirkin
2015-09-09 16:34 ` [Qemu-devel] [PATCH v2 2/2] target-i386: move asm-x86/hyperv.h to standard-headers Paolo Bonzini
2015-09-10 7:22 ` Cornelia Huck
2015-09-10 7:42 ` Michael S. Tsirkin
2015-09-10 8:04 ` Cornelia Huck
2015-09-10 9:19 ` Paolo Bonzini
2015-09-10 9:25 ` Michael S. Tsirkin
2015-09-10 9:28 ` Paolo Bonzini
2015-09-10 9:32 ` Michael S. Tsirkin [this message]
2015-09-10 9:40 ` Paolo Bonzini
2015-09-10 18:51 ` [Qemu-devel] [PATCH v2 0/2] update-linux-headers changes Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150910123113-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=den@openvz.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.