From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752598AbbIJOwd (ORCPT <rfc822;w@1wt.eu>);
	Thu, 10 Sep 2015 10:52:33 -0400
Received: from mail-pa0-f44.google.com ([209.85.220.44]:34843 "EHLO
	mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751462AbbIJOwb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 10 Sep 2015 10:52:31 -0400
Date: Thu, 10 Sep 2015 10:52:27 -0400
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <jiangshanlai@gmail.com>
Cc: sedat.dilek@gmail.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Linux v4.2] workqueue: llvmlinux: acpid: BUG: sleeping function
 called from invalid context at kernel/workqueue.c:2680
Message-ID: <20150910145227.GD8114@mtj.duckdns.org>
References: <CA+icZUV2XRX4Sx=7oofEDzxfb67AV+r-KT58zb=tTcvv4jnyew@mail.gmail.com>
 <CAJhGHyC7twT9zBbumXhMSzKzg8hf2m0Dbjw6dj7ru-Pyep+-gw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJhGHyC7twT9zBbumXhMSzKzg8hf2m0Dbjw6dj7ru-Pyep+-gw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hey,

On Thu, Sep 10, 2015 at 09:04:27AM +0800, Lai Jiangshan wrote:
> I think we need to add might_sleep() on the top of __cancel_work_timer().
> The might_sleep() on the start_flush_work() doesn't cover all the
> paths of __cancel_work_timer().
> And it can help to narrow the area of this bug.

Sure, can you submit a patch?

Thanks.

-- 
tejun