* [Buildroot] [PATCH] system: make systemd's kernel headers comment fit
@ 2015-09-10 16:55 Arnout Vandecappelle
2015-09-10 17:17 ` Yann E. MORIN
2015-09-10 20:07 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Arnout Vandecappelle @ 2015-09-10 16:55 UTC (permalink / raw)
To: buildroot
The comment line that explains that systemd needs a glibc toolchain and
kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
look as if headers >= 3.1 are needed.
Abbreviate the comment a little by removing an 'an'. It still doesn't
fit completely (only one trailing * is shown), but at least it's
readable.
While we're at it, change the quoting style to " like we always use.
Reported-by: eschu on IRC
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
system/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/system/Config.in b/system/Config.in
index fad829d..03521fd 100644
--- a/system/Config.in
+++ b/system/Config.in
@@ -90,7 +90,7 @@ config BR2_INIT_SYSTEMD
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
select BR2_PACKAGE_SYSTEMD
-comment 'systemd needs an (e)glibc toolchain, headers >= 3.10'
+comment "systemd needs (e)glibc toolchain, headers >= 3.10"
depends on !(BR2_TOOLCHAIN_USES_GLIBC \
&& BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10)
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] system: make systemd's kernel headers comment fit
2015-09-10 16:55 [Buildroot] [PATCH] system: make systemd's kernel headers comment fit Arnout Vandecappelle
@ 2015-09-10 17:17 ` Yann E. MORIN
2015-09-10 20:07 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2015-09-10 17:17 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-09-10 18:55 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The comment line that explains that systemd needs a glibc toolchain and
> kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
> look as if headers >= 3.1 are needed.
>
> Abbreviate the comment a little by removing an 'an'. It still doesn't
> fit completely (only one trailing * is shown), but at least it's
> readable.
>
> While we're at it, change the quoting style to " like we always use.
>
> Reported-by: eschu on IRC
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> system/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/system/Config.in b/system/Config.in
> index fad829d..03521fd 100644
> --- a/system/Config.in
> +++ b/system/Config.in
> @@ -90,7 +90,7 @@ config BR2_INIT_SYSTEMD
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> select BR2_PACKAGE_SYSTEMD
>
> -comment 'systemd needs an (e)glibc toolchain, headers >= 3.10'
> +comment "systemd needs (e)glibc toolchain, headers >= 3.10"
> depends on !(BR2_TOOLCHAIN_USES_GLIBC \
> && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10)
>
> --
> 2.5.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] system: make systemd's kernel headers comment fit
2015-09-10 16:55 [Buildroot] [PATCH] system: make systemd's kernel headers comment fit Arnout Vandecappelle
2015-09-10 17:17 ` Yann E. MORIN
@ 2015-09-10 20:07 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2015-09-10 20:07 UTC (permalink / raw)
To: buildroot
>>>>> "Arnout" == Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> writes:
> The comment line that explains that systemd needs a glibc toolchain and
> kernel headers >= 3.10 doesn't fit in the dialog box, which makes it
> look as if headers >= 3.1 are needed.
> Abbreviate the comment a little by removing an 'an'. It still doesn't
> fit completely (only one trailing * is shown), but at least it's
> readable.
> While we're at it, change the quoting style to " like we always use.
> Reported-by: eschu on IRC
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-09-10 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-10 16:55 [Buildroot] [PATCH] system: make systemd's kernel headers comment fit Arnout Vandecappelle
2015-09-10 17:17 ` Yann E. MORIN
2015-09-10 20:07 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.