Re: [locktorture] 5f6a140f30: kernel BUG at drivers/base/driver.c:153!

[Paul E. McKenney <paulmck@linux.vnet.ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Thu, Sep 10, 2015 at 03:59:42PM +0200, Oleg Nesterov wrote:
> On 09/09, Paul E. McKenney wrote:
> >
> > This is obsolete, but its replacement is the same patch.
> 
> fbe3b97183f84155d81e506b1aa7d2ce986f7a36 in linux-rcu.git#experimental
> I guess?
> 
> > Oleg, Davidlohr, am I missing something on how percpu_rwsem or
> > locktorture work?
> 
> No, I think the patch is fine. Thanks for doing this! I was going to
> send something like this change too. And in fact I am still thinking
> about another test which plays with rcu_sync only, but probably we
> need some cleanups first (and we need them anyway). I'll try to do
> this a bit later.

I would welcome an rcu_sync-specific torture patch!

> > +void torture_percpu_rwsem_init(void)
> > +{
> > +	BUG_ON(percpu_init_rwsem(&pcpu_rwsem));
> > +}
> > +
> 
> Aha, we don't really need this... I mean we can use the static initialiser
> which can also be used by uprobes and cgroups. I'll try to send the patch
> tomorrow.

Very good, please do!

							Thanx, Paul