All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Kyle Evans <kvans32@gmail.com>
Cc: platform-driver-x86@vger.kernel.org, Rafael Wysocki <rjw@rjwysocki.net>
Subject: Re: [PATCHv3] hp-wmi: limit hotkey enable
Date: Thu, 10 Sep 2015 10:46:58 -0700	[thread overview]
Message-ID: <20150910174658.GD113820@vmdeb7> (raw)
In-Reply-To: <55F1B391.7020601@gmail.com>

On Thu, Sep 10, 2015 at 11:45:05AM -0500, Kyle Evans wrote:
> From 0e2c0ae37e1fbc326c54a60b2845eb0c7566d389 Mon Sep 17 00:00:00 2001
> From: Kyle Evans <kvans32@gmail.com>
> Date: Tue, 1 Sep 2015 18:50:45 -0500
> Subject: [PATCH] hp-wmi: limit hotkey enable
> 
> Do not write initialize magic on systems that do not have
> feature query 0xb. Fixes Bug #82451.
> 
> Redefine FEATURE_QUERY to align with 0xb and FEATURE2 with 0xd
> for code clearity.
> 
> Add a new test function, hp_wmi_bios_2008_later() & simplify
> hp_wmi_bios_2009_later(), which fixes a bug in cases where
> an improper value is returned. May also fix Bug #69131.
> 
> Signed-off-by: Kyle Evans <kvans32@gmail.com>

Thanks Kyle,

I think this looks much better. Unfortunately, it doesn't apply to either Linus'
master nor my for-next branch, with all 3 hunks failing even with the more
forgiving manual patch application. Please check your base and regenerate based
on either Linus' master (the usual approach) or my for-next branch.

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2015-09-10 17:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 14:56 [PATCH] hp-wmi: limit hotkey enable Kyle Evans
2015-08-28 18:42 ` Darren Hart
2015-08-29 15:26   ` Kyle Evans
2015-09-06 18:03     ` Darren Hart
2015-09-08 15:58       ` Kyle Evans
2015-09-08 18:29       ` Kyle Evans
2015-09-08 20:22         ` Darren Hart
2015-09-09 20:32           ` Kyle Evans
2015-09-10  3:19             ` Darren Hart
2015-09-10 16:45               ` [PATCHv3] " Kyle Evans
2015-09-10 17:46                 ` Darren Hart [this message]
2015-09-10 19:47                   ` Kyle Evans
2015-09-10 17:45               ` [PATCHv4] " Kyle Evans
2015-09-10 21:21                 ` Darren Hart
2015-09-11 15:05                   ` Kyle Evans
2015-09-11 15:40               ` [PATCHv5] " Kyle Evans
2015-09-11 15:55                 ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150910174658.GD113820@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=kvans32@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.