From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Kirill Tkhai <ktkhai@parallels.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs
Date: Fri, 11 Sep 2015 15:54:38 +0530 [thread overview]
Message-ID: <20150911102438.GA7579@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150910130750.GA20055@redhat.com>
* Oleg Nesterov <oleg@redhat.com> [2015-09-10 15:07:50]:
> check_for_tasks() doesn't need to disable irqs, recursive read_lock()
> from interrupt is fine.
>
> While at it, s/do_each_thread/for_each_process_thread/.
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> ---
> kernel/cpu.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2015-09-11 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 13:07 [PATCH] check_for_tasks: read_lock(tasklist_lock) doesn't need to disable irqs Oleg Nesterov
2015-09-10 13:31 ` Kirill Tkhai
2015-09-11 10:24 ` Srikar Dronamraju [this message]
2015-09-13 10:56 ` [tip:sched/core] cpu/hotplug: Read_lock(tasklist_lock) doesn' t " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150911102438.GA7579@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.