All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC v2] support/misc: Adding Vagrant file for provisioning
Date: Fri, 11 Sep 2015 11:34:14 +0200	[thread overview]
Message-ID: <20150911113414.5826a5af@free-electrons.com> (raw)
In-Reply-To: <CAHsRNLj0ogoFvjapJoCix9=7Cv4yv53VeASYG70+_CF2wXrgLQ@mail.gmail.com>

Gabe, Angelo,

On Thu, 10 Sep 2015 14:56:45 -0700, Gabe Evans wrote:

> > +require 'open-uri'
> > +open("http://git.buildroot.net/buildroot/plain/CHANGES") do |f|
> > +  BUILDROOT_VERSION=f.read.lines.first.split(",")[0]
> > +end
> 
> As it is now, CHANGES will be redownloaded every time a vagrant
> command is issued. Can this be moved into $script so that it's only
> executed once during provisioning? This bit could be written in shell
> with something like:
> 
>     curl -s http://git.buildroot.net/buildroot/plain/CHANGES | head -1
> | awk -F ',' '{print $1}'
> 
> Though, I'm not sure if there's a better way to determine the current
> released Buildroot version.

Does it make sense for this provisioning script to randomly pick-up the
latest Buildroot version? Angelo is selling this provisioning script as
a way for several users to have an identical, reproducible, build
environment. But if it randomly picks up the latest Buildroot version,
it kind of defeats that purpose.

So shouldn't the Buildroot version simply be hardcoded in the script
and/or passed as argument in some way?

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-09-11  9:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 21:12 [Buildroot] [RFC v2] support/misc: Adding Vagrant file for provisioning Angelo Compagnucci
2015-09-10 21:56 ` Gabe Evans
2015-09-11  9:34   ` Thomas Petazzoni [this message]
2015-09-11  9:42     ` Angelo Compagnucci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911113414.5826a5af@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.