From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56012)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZaPHQ-0005OV-QP
	for qemu-devel@nongnu.org; Fri, 11 Sep 2015 10:26:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZaPHN-0006ZA-K2
	for qemu-devel@nongnu.org; Fri, 11 Sep 2015 10:26:20 -0400
Received: from mail-bn1on0086.outbound.protection.outlook.com
	([157.56.110.86]:64688
	helo=na01-bn1-obe.outbound.protection.outlook.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@xilinx.com>) id 1ZaPHN-0006YV-EV
	for qemu-devel@nongnu.org; Fri, 11 Sep 2015 10:26:17 -0400
Date: Fri, 11 Sep 2015 16:26:10 +0200
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Message-ID: <20150911142610.GL12618@toto>
References: <1441497448-32489-1-git-send-email-T.E.Baldwin99@members.leeds.ac.uk>
	<1441497448-32489-34-git-send-email-T.E.Baldwin99@members.leeds.ac.uk>
	<CAFEAcA9qmG2aq4e0j8fHX+1uLiVczj=bMy7DYZd75zEOsrfL8w@mail.gmail.com>
	<20150911140035.GK12618@toto>
	<CAFEAcA9g4feNX4HKWPAWDovtwT043i_MFGEXAvPKKoTvdZoCWA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <CAFEAcA9g4feNX4HKWPAWDovtwT043i_MFGEXAvPKKoTvdZoCWA@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH 33/34] linux-user: Support for restarting
 system calls for CRIS targets
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Edgar E.
	Iglesias" <edgar.iglesias@gmail.com>, Riku Voipio <riku.voipio@iki.fi>, Timothy E Baldwin <T.E.Baldwin99@members.leeds.ac.uk>, QEMU Developers <qemu-devel@nongnu.org>

On Fri, Sep 11, 2015 at 03:20:31PM +0100, Peter Maydell wrote:
> On 11 September 2015 at 15:18, Edgar E. Iglesias
> <edgar.iglesias@xilinx.com> wrote:
> > On Thu, Sep 10, 2015 at 08:12:21PM +0100, Peter Maydell wrote:
> >> On 6 September 2015 at 00:57, Timothy E Baldwin
> >> <T.E.Baldwin99@members.leeds.ac.uk> wrote:
> >> > Signed-off-by: Timothy Edward Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
> >> > ---
> >> >
> >> > WARNING - NOT TESTED
> >> >
> >> >  linux-user/cris/syscall.h | 2 ++
> >> >  linux-user/main.c         | 6 +++++-
> >> >  linux-user/signal.c       | 2 +-
> >> >  3 files changed, 8 insertions(+), 2 deletions(-)
> 
> 
> >> Looks OK, but this one I'm not sure enough about the CRIS instruction
> >> set and the surrounding code doesn't clarify. Edgar -- is the CRIS
> >> instruction for "take linux system call" always exactly 2 bytes long?
> >>
> >
> > Yes, those are always 2 bytes.
> 
> Cool. In that case
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>

Thanks, me too:

Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>