diff for duplicates of <20150911162749.GD18779@x1> diff --git a/a/1.txt b/N1/1.txt index b23cf9a..f77395a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -17,12 +17,12 @@ On Fri, 11 Sep 2015, Peter Griffin wrote: > }; > }; > + -> + fdma0: fdma0-audio at 8e20000 { +> + fdma0: fdma0-audio@8e20000 { I'm not familiar with the FDMA driver, so can't comment knowledgeably, but the <dev> part of <dev>@<base_address> should only describe the type of hardware. I believe in this case it should just be -dma at 08e20000. Also notice the leading zero in the address, which I +dma@08e20000. Also notice the leading zero in the address, which I believe mitigates possible confusion. Then you be more specific with the label, so something like 'fdma-audio' seems appropriate here. @@ -49,7 +49,7 @@ this case? > + "fdma_ic"; > + }; > + -> + fdma1: fdma1-app at 8e40000 { +> + fdma1: fdma1-app@8e40000 { > + compatible = "st,stih407-fdma-mpe31"; > + reg = <0x8e40000 0x20000>; > + interrupts = <GIC_SPI 7 IRQ_TYPE_NONE>; @@ -66,7 +66,7 @@ this case? > + "fdma_ic"; > + }; > + -> + fdma2: fdma2-free_running at 8e60000 { +> + fdma2: fdma2-free_running@8e60000 { > + compatible = "st,stih407-fdma-mpe31"; > + reg = <0x8e60000 0x20000>; > + interrupts = <GIC_SPI 9 IRQ_TYPE_NONE>; @@ -88,5 +88,5 @@ this case? -- Lee Jones Linaro STMicroelectronics Landing Team Lead -Linaro.org ? Open source software for ARM SoCs +Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog diff --git a/a/content_digest b/N1/content_digest index fc98f84..9c6afcf 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,9 +1,18 @@ "ref\01441980871-24475-1-git-send-email-peter.griffin@linaro.org\0" "ref\01441980871-24475-8-git-send-email-peter.griffin@linaro.org\0" - "From\0lee.jones@linaro.org (Lee Jones)\0" - "Subject\0[PATCH v2 7/9] ARM: STi: DT: STiH407: Add FDMA driver dt nodes.\0" + "From\0Lee Jones <lee.jones@linaro.org>\0" + "Subject\0Re: [PATCH v2 7/9] ARM: STi: DT: STiH407: Add FDMA driver dt nodes.\0" "Date\0Fri, 11 Sep 2015 17:27:49 +0100\0" - "To\0linux-arm-kernel@lists.infradead.org\0" + "To\0Peter Griffin <peter.griffin@linaro.org>\0" + "Cc\0linux-arm-kernel@lists.infradead.org" + linux-kernel@vger.kernel.org + srinivas.kandagatla@gmail.com + maxime.coquelin@st.com + patrice.chotard@st.com + vinod.koul@intel.com + robh+dt@kernel.org + dmaengine@vger.kernel.org + " devicetree@vger.kernel.org\0" "\00:1\0" "b\0" "On Fri, 11 Sep 2015, Peter Griffin wrote:\n" @@ -25,12 +34,12 @@ "> \t\t\t};\n" "> \t\t};\n" "> +\n" - "> +\t\tfdma0: fdma0-audio at 8e20000 {\n" + "> +\t\tfdma0: fdma0-audio@8e20000 {\n" "\n" "I'm not familiar with the FDMA driver, so can't comment knowledgeably,\n" "but the <dev> part of <dev>@<base_address> should only describe the\n" "type of hardware. I believe in this case it should just be\n" - "dma at 08e20000. Also notice the leading zero in the address, which I\n" + "dma@08e20000. Also notice the leading zero in the address, which I\n" "believe mitigates possible confusion. Then you be more specific with\n" "the label, so something like 'fdma-audio' seems appropriate here.\n" "\n" @@ -57,7 +66,7 @@ "> +\t\t\t\t \"fdma_ic\";\n" "> +\t\t};\n" "> +\n" - "> +\t\tfdma1: fdma1-app at 8e40000 {\n" + "> +\t\tfdma1: fdma1-app@8e40000 {\n" "> +\t\t\tcompatible = \"st,stih407-fdma-mpe31\";\n" "> +\t\t\treg = <0x8e40000 0x20000>;\n" "> +\t\t\tinterrupts = <GIC_SPI 7 IRQ_TYPE_NONE>;\n" @@ -74,7 +83,7 @@ "> +\t\t\t\t \"fdma_ic\";\n" "> +\t\t};\n" "> +\n" - "> +\t\tfdma2: fdma2-free_running at 8e60000 {\n" + "> +\t\tfdma2: fdma2-free_running@8e60000 {\n" "> +\t\t\tcompatible = \"st,stih407-fdma-mpe31\";\n" "> +\t\t\treg = <0x8e60000 0x20000>;\n" "> +\t\t\tinterrupts = <GIC_SPI 9 IRQ_TYPE_NONE>;\n" @@ -96,7 +105,7 @@ "-- \n" "Lee Jones\n" "Linaro STMicroelectronics Landing Team Lead\n" - "Linaro.org ? Open source software for ARM SoCs\n" + "Linaro.org \342\224\202 Open source software for ARM SoCs\n" Follow Linaro: Facebook | Twitter | Blog -c8cb01fc84527e51bd814ea259fe5472bf78e3ad0ff3377b762e7665a938ad03 +07530257ab30e42556a76ef4725d629040454b9ae874540f99d7b6cec4043e4e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.