From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754609AbbILEfg (ORCPT ); Sat, 12 Sep 2015 00:35:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:57860 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754537AbbILEfd (ORCPT ); Sat, 12 Sep 2015 00:35:33 -0400 Date: Fri, 11 Sep 2015 19:57:00 -0700 From: Greg KH To: Aparna Karuthodi Cc: kirk@reisers.ca, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, speakup@linux-speakup.org Subject: Re: [PATCH] staging: speakup: Changed simple_strtoul to kstrtoul Message-ID: <20150912025700.GA17805@kroah.com> References: <1441984640-11562-1-git-send-email-kdasaparna@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441984640-11562-1-git-send-email-kdasaparna@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 11, 2015 at 08:47:20PM +0530, Aparna Karuthodi wrote: > Used kstrtoul instead of simple_strtoul to remove a warning detected by > checkpatch.The warning is given below: > drivers/staging/speakup/varhandlers.c:327: WARNING: simple_strtoul is > obsolete, use kstrtoul instead > > Signed-off-by: Aparna Karuthodi > --- > drivers/staging/speakup/varhandlers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c > index 1b0d1c0..00fd67e 100644 > --- a/drivers/staging/speakup/varhandlers.c > +++ b/drivers/staging/speakup/varhandlers.c > @@ -324,7 +324,7 @@ char *spk_s2uchar(char *start, char *dest) > { > int val = 0; > > - val = simple_strtoul(skip_spaces(start), &start, 10); > + val = kstrtoul(skip_spaces(start), &start, 10); > if (*start == ',') > start++; > *dest = (u_char)val; You obviously did not even compile this patch, which is quite rude, don't you think?