All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,06/10] dfu: mmc: buffer file reads too
Date: Sat, 12 Sep 2015 08:51:31 -0400	[thread overview]
Message-ID: <20150912125131.GD26226@bill-the-cat> (raw)
In-Reply-To: <1441425831-3441-6-git-send-email-swarren@wwwdotorg.org>

On Fri, Sep 04, 2015 at 10:03:47PM -0600, Stephen Warren wrote:

> From: Stephen Warren <swarren@nvidia.com>
> 
> When writing to files in a filesystem on MMC, dfu_mmc.c buffers up the
> entire file content until the end of the transaction, at which point the
> file is written in one go. This allows writing files larger than the USB
> transfer size (CONFIG_SYS_DFU_DATA_BUF_SIZE); the maximum written file
> size is CONFIG_SYS_DFU_MAX_FILE_SIZE (the size of the temporary buffer).
> 
> The current file reading code does not do any buffering, and so limits
> the maximum read file size to the USB transfer size. Enhance the code to
> do the same kind of buffering as the write path, so the same file size
> limits apply.
> 
> Remove the size checking code from dfu_read() since all read paths now
> support larger files than the USB transfer buffer.
> 
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Tested-by: Lukasz Majewski <l.majewski@samsung.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150912/05b1c8a0/attachment.sig>

  parent reply	other threads:[~2015-09-12 12:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-05  4:03 [U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding Stephen Warren
2015-09-05  4:03 ` [U-Boot] [PATCH 02/10] ext4: avoid calling ext4fs_mount() twice, which leaks Stephen Warren
2015-09-08 13:22   ` Lukasz Majewski
2015-09-12 12:51   ` [U-Boot] [U-Boot, " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 03/10] ext4: free allocations by parse_path() Stephen Warren
2015-09-08 13:10   ` Lukasz Majewski
2015-09-12 12:51   ` [U-Boot] [U-Boot,03/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 04/10] ext4: fix leak in check_filename() Stephen Warren
2015-09-08 13:05   ` Lukasz Majewski
2015-09-12 12:51   ` [U-Boot] [U-Boot,04/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 05/10] dfu: don't keep freeing/reallocating Stephen Warren
2015-09-08 12:32   ` Lukasz Majewski
2015-09-12 12:51   ` [U-Boot] [U-Boot,05/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 06/10] dfu: mmc: buffer file reads too Stephen Warren
2015-09-08 12:57   ` Lukasz Majewski
2015-09-12 12:51   ` Tom Rini [this message]
2015-09-05  4:03 ` [U-Boot] [PATCH 07/10] ARM: tegra: fix malloc region sizing Stephen Warren
2015-09-08 16:53   ` Tom Warren
2015-09-08 21:45     ` Stephen Warren
2015-09-08 21:52       ` Stephen Warren
2015-09-08 21:56         ` Tom Rini
2015-09-08 21:56           ` Stephen Warren
2015-09-09  6:51         ` Lukasz Majewski
2015-09-09 16:08           ` Tom Warren
2015-09-12 12:51   ` [U-Boot] [U-Boot,07/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 08/10] ARM: tegra: tweak DFU buffer sizes Stephen Warren
2015-09-12 12:51   ` [U-Boot] [U-Boot,08/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 09/10] ARM: tegra: enable filesystem writing Stephen Warren
2015-09-12 12:51   ` [U-Boot] [U-Boot,09/10] " Tom Rini
2015-09-05  4:03 ` [U-Boot] [PATCH 10/10] ARM: tegra: enable DFU for RAM Stephen Warren
2015-09-12 12:51   ` [U-Boot] [U-Boot,10/10] " Tom Rini
2015-09-08 12:00 ` [U-Boot] [PATCH 01/10] usb: gadget: don't leak configs when unbinding Lukasz Majewski
2015-09-08 21:50   ` Stephen Warren
2015-09-12 12:51 ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150912125131.GD26226@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.