From: Vincent Pelletier <plr.vincent@gmail.com>
To: Simon Guinot <simon.guinot@sequanux.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Vincent Donnefort <vdonnefort@gmail.com>,
Yoann Sculo <yoann@sculo.fr>
Subject: Re: [1/4] gpio: gpio-f7188x: Use mutex for access serialisation.
Date: Sat, 12 Sep 2015 15:26:43 +0200 [thread overview]
Message-ID: <20150912152643.4e5bb384@x2> (raw)
In-Reply-To: <20150909220140.GD9892@kw.sim.vm.gnt>
Hello Simon,
On Thu, 10 Sep 2015 00:01:40 +0200, Simon Guinot
<simon.guinot@sequanux.org> wrote:
> Vincent (Donnefort) finally succeeds to reproduce the issue. The setup
> is quite simple. You only have to flood the gpio-f7188x driver via the
> sysfs GPIO interface. Nothing more is needed.
>
> After some debugging we discovered that the problem comes from the
> __request_region function which don't handle very well concurrent
> requests on a muxed region.
>
> I will send a patch as a reply to this email. Please, can you test it ?
I reverted my mutex-adding commit, applied given patch, and could not
reproduce the error after a few minutes with my test-case, so I think
this solves the issue.
Tested-by: Vincent Pelletier <plr.vincent@gmail.com>
I rebased my others gpio patches, unrelated to this issue:
gpio: gpio-f7188x: Implement get_direction.
gpio: gpio-f7188x: "get" should retrieve sensed level when available.
gpio: gpio-f7188x: GPIO bank 0 bit 0 is not available on f71869a
Should I resend ?
I have not checked other model's datasheets, FWIW.
Regards,
--
Vincent Pelletier
next prev parent reply other threads:[~2015-09-12 13:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-20 18:03 gpio-f7188x: Fix concurrent GPIO accesses (and minor improvements) Vincent Pelletier
2015-08-20 18:03 ` [1/4] gpio: gpio-f7188x: Use mutex for access serialisation Vincent Pelletier
2015-08-20 18:03 ` [2/4] gpio: gpio-f7188x: GPIO bank 0 bit 0 is not available on f71869a Vincent Pelletier
2015-08-20 18:03 ` [3/4] gpio: gpio-f7188x: "get" should retrieve sensed level when available Vincent Pelletier
2015-08-20 18:03 ` [4/4] gpio: gpio-f7188x: Implement get_direction Vincent Pelletier
2015-08-21 17:52 ` [1/4] gpio: gpio-f7188x: Use mutex for access serialisation Simon Guinot
2015-08-21 20:48 ` Vincent Pelletier
2015-08-22 17:04 ` Vincent Pelletier
2015-09-03 18:05 ` Vincent Pelletier
2015-09-04 7:39 ` Simon Guinot
2015-09-09 22:01 ` Simon Guinot
2015-09-09 22:15 ` [PATCH] kernel/resource.c: fix muxed resource handling in __request_region() Simon Guinot
2016-02-19 21:10 ` Vincent Pelletier
2016-02-19 23:25 ` Jesse Barnes
2016-02-20 17:11 ` Linus Torvalds
2016-02-20 22:15 ` Jesse Barnes
2016-02-20 22:15 ` Jesse Barnes
2016-02-22 13:49 ` Alan Cox
2016-02-22 20:46 ` Jesse Barnes
2016-02-23 16:19 ` Simon Guinot
2016-02-23 17:19 ` Jesse Barnes
2016-02-23 21:38 ` One Thousand Gnomes
2016-02-24 14:25 ` [PATCH] kernel/resource.c: ensure parent is not freed " Simon Guinot
2016-02-23 8:00 ` [PATCH] kernel/resource.c: fix muxed resource handling " Vincent Pelletier
2015-09-12 13:26 ` Vincent Pelletier [this message]
2015-09-04 13:48 ` [1/4] gpio: gpio-f7188x: Use mutex for access serialisation Vincent Donnefort
2015-09-05 7:43 ` Vincent Pelletier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150912152643.4e5bb384@x2 \
--to=plr.vincent@gmail.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon.guinot@sequanux.org \
--cc=vdonnefort@gmail.com \
--cc=yoann@sculo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.