All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: dsa: mv88e6xxx: Allow speed/duplex of port to be configured
Date: Sat, 12 Sep 2015 19:59:13 +0000	[thread overview]
Message-ID: <20150912195913.GA11157@mwanda> (raw)

Hello Andrew Lunn,

The patch dea870242a9c: "dsa: mv88e6xxx: Allow speed/duplex of port
to be configured" from Aug 31, 2015, leads to the following static
checker warning:

	drivers/net/dsa/mv88e6xxx.c:585 mv88e6xxx_adjust_link()
	warn: unsigned 'ret' is never less than zero.

drivers/net/dsa/mv88e6xxx.c
   573  void mv88e6xxx_adjust_link(struct dsa_switch *ds, int port,
   574                             struct phy_device *phydev)
   575  {
   576          struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
   577          u32 ret, reg;
   578  
   579          if (!phy_is_pseudo_fixed_link(phydev))
   580                  return;
   581  
   582          mutex_lock(&ps->smi_mutex);
   583  
   584          ret = _mv88e6xxx_reg_read(ds, REG_PORT(port), PORT_PCS_CTRL);
   585          if (ret < 0)

Probably make ret an int.

   586                  goto out;
   587  

regards,
dan carpenter

             reply	other threads:[~2015-09-12 19:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-12 19:59 Dan Carpenter [this message]
2015-09-22  1:35 ` dsa: mv88e6xxx: Allow speed/duplex of port to be configured Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150912195913.GA11157@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.