All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline
Date: Sun, 13 Sep 2015 23:31:14 +0200	[thread overview]
Message-ID: <20150913233114.327f1428@free-electrons.com> (raw)
In-Reply-To: <1442178981-24635-1-git-send-email-0intro@gmail.com>

David,

Thanks for this contribution!

On Sun, 13 Sep 2015 23:16:21 +0200, David du Colombier wrote:
> When linking statically, the order of libraries on the
> linker command matters, since readline depends on ncurses.
> 
> Signed-off-by: David du Colombier <0intro@gmail.com>
> ---
>  package/wpa_supplicant/0005-fix-readline-libs-ordering.patch | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
> 
> diff --git a/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
> new file mode 100644
> index 0000000..b2439f0
> --- /dev/null
> +++ b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch

Thanks for the patch, but patches in Buildroot have to have a
description and a Signed-off-by line. See
http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

Also, could you submit this patch to upstream wpa_supplicant?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-09-13 21:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-13 21:16 [Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline David du Colombier
2015-09-13 21:31 ` Thomas Petazzoni [this message]
2015-09-13 21:50   ` David du Colombier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150913233114.327f1428@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.