From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] drm/mgag200: fix memory leak Date: Mon, 14 Sep 2015 15:59:51 +0530 Message-ID: <20150914102951.GA23251@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f49.google.com (mail-pa0-f49.google.com [209.85.220.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 376C76E010 for ; Mon, 14 Sep 2015 03:30:01 -0700 (PDT) Received: by padhk3 with SMTP id hk3so140649830pad.3 for ; Mon, 14 Sep 2015 03:30:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dave Airlie Cc: Daniel Vetter , LKML , dri-devel , Archit Taneja , Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBTZXAgMTQsIDIwMTUgYXQgMDg6MDU6MzdQTSArMTAwMCwgRGF2ZSBBaXJsaWUgd3Jv dGU6Cj4gKHRoaXMgdGltZSB3aXRoIGNvcnJlY3QgZW1haWwgYWRkcmVzcykuCj4gCj4gT24gMTQg U2VwdGVtYmVyIDIwMTUgYXQgMjA6MDQsIERhdmUgQWlybGllIDxhaXJsaWVkQGdtYWlsLmNvbT4g d3JvdGU6Cj4gPj4KPiA+Pgo+ID4+IFRoZXJlJ3MgYSBuZXcgcmVncmVzc2lvbjogdjQuMy1yYzEg Y3Jhc2hlcyBvbiBib290dXAgb24gbm9uLXN1cHBvcnRlZCBoYXJkd2FyZSwgaWYKPiA+PiBDT05G SUdfRFJNX01HQUcyMDA9eSAoYnVpbHQgaW50byB0aGUga2VybmVsKS4KPiA+Cj4gPiBBcmNoaXQs IEknbSBndWVzc2luZyB0aGlzIGlzIHNvbWUgZmFsbG91dCBmcm9tIHRoZSBmYmRldiBjaGFuZ2Vz Lgo+ID4KPiA+IFRoZXJlIGlzIG5vIHJlYXNvbiB3ZSBzaG91bGQgbmVlZCBDT05GSUdfRkJfTElU VExFX0VORElBTiBJIGRvbid0IHRoaW5rLgpJIGFtIGFzc3VtaW5nIHY0LjIgaGFzIHdvcmtlZCBm b3IgSW5nby4gU28gaW4gdGhhdCBjYXNlIEkgZG9uJ3Qgc2VlIGFueQpjaGFuZ2UgaW4gZmJkZXYv Y29yZS9mYm1lbS5jIGJldHdlZW4gNC4yIGFuZCA0LjMtcmMxLiBCdXQgaW4gZHJtIChJCmFsbW9z dCBrbm93IG5vdGhpbmcgYWJvdXQgZHJtKSBjb21taXQgZTgyOWQ3ZWY5ZjE3IGNoYW5nZXMgZmV3 IGNvZGVzCnJlbGF0ZWQgdG8gdGhlIGNhcmQgcmV2aXNpb24uIENhbiB0aGlzIGhlbHA/CgpyZWdh cmRzCnN1ZGlwCgoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tZ2FnMjAwL21nYWcyMDBf bW9kZS5jIGIvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9tb2RlLmMKaW5kZXggYzk5 ZDNmZS4uNWNkZmE1MyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIw MF9tb2RlLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL21nYWcyMDAvbWdhZzIwMF9tb2RlLmMKQEAg LTE2MDIsNyArMTYwMiw3IEBAIHN0YXRpYyBpbnQgbWdhX3ZnYV9tb2RlX3ZhbGlkKHN0cnVjdCBk cm1fY29ubmVjdG9yICpjb25uZWN0b3IsCiAJCQlpZiAobWdhX3ZnYV9jYWxjdWxhdGVfbW9kZV9i YW5kd2lkdGgobW9kZSwgYnBwKQogCQkJCT4gKDI0NDAwICogMTAyNCkpCiAJCQkJcmV0dXJuIE1P REVfQkFORFdJRFRIOwotCQl9IGVsc2UgaWYgKG1kZXYtPnVuaXF1ZV9yZXZfaWQgPT0gMHgwMikg eworCQl9IGVsc2UgaWYgKG1kZXYtPnVuaXF1ZV9yZXZfaWQgPj0gMHgwMikgewogCQkJaWYgKG1v ZGUtPmhkaXNwbGF5ID4gMTkyMCkKIAkJCQlyZXR1cm4gTU9ERV9WSVJUVUFMX1g7CiAJCQlpZiAo bW9kZS0+dmRpc3BsYXkgPiAxMjAwKQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754961AbbINKaD (ORCPT ); Mon, 14 Sep 2015 06:30:03 -0400 Received: from mail-pa0-f42.google.com ([209.85.220.42]:33871 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbbINKaB (ORCPT ); Mon, 14 Sep 2015 06:30:01 -0400 Date: Mon, 14 Sep 2015 15:59:51 +0530 From: Sudip Mukherjee To: Dave Airlie Cc: Ingo Molnar , architt@codeaurora.org, David Airlie , Daniel Vetter , LKML , dri-devel , Archit Taneja Subject: Re: [PATCH] drm/mgag200: fix memory leak Message-ID: <20150914102951.GA23251@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 14, 2015 at 08:05:37PM +1000, Dave Airlie wrote: > (this time with correct email address). > > On 14 September 2015 at 20:04, Dave Airlie wrote: > >> > >> > >> There's a new regression: v4.3-rc1 crashes on bootup on non-supported hardware, if > >> CONFIG_DRM_MGAG200=y (built into the kernel). > > > > Archit, I'm guessing this is some fallout from the fbdev changes. > > > > There is no reason we should need CONFIG_FB_LITTLE_ENDIAN I don't think. I am assuming v4.2 has worked for Ingo. So in that case I don't see any change in fbdev/core/fbmem.c between 4.2 and 4.3-rc1. But in drm (I almost know nothing about drm) commit e829d7ef9f17 changes few codes related to the card revision. Can this help? regards sudip diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c index c99d3fe..5cdfa53 100644 --- a/drivers/gpu/drm/mgag200/mgag200_mode.c +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c @@ -1602,7 +1602,7 @@ static int mga_vga_mode_valid(struct drm_connector *connector, if (mga_vga_calculate_mode_bandwidth(mode, bpp) > (24400 * 1024)) return MODE_BANDWIDTH; - } else if (mdev->unique_rev_id == 0x02) { + } else if (mdev->unique_rev_id >= 0x02) { if (mode->hdisplay > 1920) return MODE_VIRTUAL_X; if (mode->vdisplay > 1200)