From: Jonathan Corbet <corbet@lwn.net>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, vince@deater.net,
eranian@google.com, johannes@sipsolutions.net,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH RFC v3 1/6] exterr: Introduce extended syscall error reporting
Date: Mon, 14 Sep 2015 15:59:20 -0600 [thread overview]
Message-ID: <20150914155920.449b405a@lwn.net> (raw)
In-Reply-To: <1441987205-4021-2-git-send-email-alexander.shishkin@linux.intel.com>
One more little thing:
> +int ext_err_copy_to_user(void __user *buf, size_t size)
> +{
[...]
> + ret = copy_to_user(buf, output, len + 1);
> +
> + kfree(output);
> +
> + if (!ret)
> + current->ext_err_code = 0;
> +
> + return ret ? ret : len + 1;
> +}
I'm pretty sure you really want something like:
return ret ? -EFAULT : (len + 1);
here.
jon
next prev parent reply other threads:[~2015-09-14 21:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 15:59 [PATCH RFC v3 0/6] Introduce extended syscall error reporting Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 1/6] exterr: " Alexander Shishkin
2015-09-14 20:19 ` Jonathan Corbet
2015-09-15 14:15 ` Alexander Shishkin
2015-09-15 14:31 ` Johannes Berg
2015-09-15 15:24 ` Alexander Shishkin
[not found] ` <877fnrn1sj.fsf-qxRn5AmX6ZD9BXuAQUXR0fooFf0ArEBIu+b9c/7xato@public.gmane.org>
2015-09-15 16:35 ` Jonathan Corbet
2015-09-15 16:35 ` Jonathan Corbet
[not found] ` <20150915103556.36b06f09-T1hC0tSOHrs@public.gmane.org>
2015-09-15 17:02 ` Johannes Berg
2015-09-15 17:02 ` Johannes Berg
2015-09-14 21:59 ` Jonathan Corbet [this message]
2016-01-11 10:34 ` Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 2/6] perf: Use " Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 3/6] perf/x86: Annotate a BTS error with extended " Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 4/6] perf tools: Add a simple JSON parser Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 5/6] perf tools: Add userspace counterpart for extended error reporting Alexander Shishkin
2015-09-11 16:00 ` [PATCH RFC v3 6/6] perf tools: Use extended syscall " Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914155920.449b405a@lwn.net \
--to=corbet@lwn.net \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=eranian@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vince@deater.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.