All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rafael Wysocki <rjw@rjwysocki.net>,
	linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	alexandra.yates@linux.intel.com, Len Brown <len.brown@intel.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG
Date: Tue, 15 Sep 2015 13:02:45 +0200	[thread overview]
Message-ID: <20150915110244.GA25425@amd> (raw)
In-Reply-To: <e7097f9c9cc28de234486e3f3865bf9bbea92aac.1442304707.git.viresh.kumar@linaro.org>

On Tue 2015-09-15 13:42:21, Viresh Kumar wrote:
> The variable 'wakeup_irq' is defined within #ifdef CONFIG_PM_SLEEP_DEBUG
> and used outside of it. And that breaks kernel build:
> 
> /home/viresh/linux/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> /home/viresh/drivers/base/power/wakeup.c:871: undefined reference to `wakeup_irq'
> 
> Fix it by defining the variable outside of the ifdef.
> 
> Fixes: d1e59c235322 ("PM / sleep: Report interrupt that caused system wakeup")
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

Acked-by: Pavel Machek <pavel@ucw.cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2015-09-15 11:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-15  8:12 [PATCH] PM / sleep: Fix broken builds without CONFIG_PM_SLEEP_DEBUG Viresh Kumar
2015-09-15  8:12 ` Viresh Kumar
2015-09-15 11:02 ` Pavel Machek [this message]
2015-09-16  1:43 ` Rafael J. Wysocki
2015-09-16  2:00   ` Viresh Kumar
2015-09-16  2:48     ` Rafael J. Wysocki
2015-09-16  2:54       ` Rafael J. Wysocki
2015-09-16  2:30         ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150915110244.GA25425@amd \
    --to=pavel@ucw.cz \
    --cc=alexandra.yates@linux.intel.com \
    --cc=len.brown@intel.com \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=tglx@linutronix.de \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.