From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
mingo@kernel.org, kan.liang@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3 00/14] perf tools: Fix gaps propagating maps
Date: Tue, 15 Sep 2015 10:06:19 -0300 [thread overview]
Message-ID: <20150915130619.GA2346@redhat.com> (raw)
In-Reply-To: <55F7C048.2000203@intel.com>
Em Tue, Sep 15, 2015 at 09:52:56AM +0300, Adrian Hunter escreveu:
> On 08/09/15 11:08, Jiri Olsa wrote:
> > On Tue, Sep 08, 2015 at 10:58:48AM +0300, Adrian Hunter wrote:
> >> Hi
> >>
> >> Here is V3 of "Fix gaps propagating maps" that fixes some problems
> >> revealed by to d988d5ee6478 ("perf evlist: Open event on evsel cpus and threads")
> >>
> >> Changes in V3:
> >>
> >> perf tools: Remove redundant validation from perf_evlist__propagate_maps
> >> perf_evlist__set_maps also doesn't need to return an error anymore
> >>
> >> perf tools: Add evlist->has_user_cpus
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps()
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix perf_evlist__create_syswide_maps() not propagating maps
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix task exit test setting maps
> >> Adjusted due to perf_evlist__set_maps change
> >>
> >> perf tools: Fix software clock events test setting maps
> >> Adjusted due to perf_evlist__set_maps change
> >
> > Acked-by: Jiri Olsa <jolsa@kernel.org>
>
> Hi Arnaldo
>
> Please don't forget these. Intel PT is broken on 4.3 without them i.e.
>
> $ tools/perf/perf --version
> perf version 4.3.rc1.gd25ed
> $ tools/perf/perf record -e intel_pt//u uname
> Error:
> The sys_perf_event_open() syscall returned with 22 (Invalid argument) for
> event (sched:sched_switch).
Ok, so this needs to go to perf/urgent, checking them now.
- Arnaldo
next prev parent reply other threads:[~2015-09-15 13:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-08 7:58 [PATCH V3 00/14] perf tools: Fix gaps propagating maps Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 01/14] perf tools: Simplify perf_evlist__propagate_maps logic Adrian Hunter
2015-09-16 7:30 ` [tip:perf/core] perf evlist: Simplify propagate_maps() logic tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 02/14] perf tools: Simplify perf_evlist__set_maps logic Adrian Hunter
2015-09-16 7:31 ` [tip:perf/core] perf evlist: Simplify set_maps() logic tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 03/14] perf tools: Remove redundant validation from perf_evlist__propagate_maps Adrian Hunter
2015-09-16 7:31 ` [tip:perf/core] perf evlist: Remove redundant validation from propagate_maps() tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 04/14] perf tools: Add evlist->has_user_cpus Adrian Hunter
2015-09-16 7:32 ` [tip:perf/core] perf evlist: Add has_user_cpus member tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 05/14] perf tools: Fix perf_evlist__splice_list_tail not setting evlist Adrian Hunter
2015-09-16 7:32 ` [tip:perf/core] perf evlist: Fix splice_list_tail() " tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 06/14] perf tools: Fix missing thread_map__put in perf_evlist__propagate_maps Adrian Hunter
2015-09-16 7:32 ` [tip:perf/core] perf evlist: Fix missing thread_map__put in propagate_maps() tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 07/14] perf tools: Add evsel->own_cpus Adrian Hunter
2015-09-16 7:33 ` [tip:perf/core] perf evsel: Add own_cpus member tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 08/14] perf tools: Make perf_evlist__set_maps() more resilient Adrian Hunter
2015-09-16 7:33 ` [tip:perf/core] perf evlist: Make set_maps() " tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 09/14] perf tools: Make perf_evlist__create_maps() use perf_evlist__set_maps() Adrian Hunter
2015-09-16 7:33 ` [tip:perf/core] perf evlist: Make create_maps() use set_maps() tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 10/14] perf tools: Factor out a function to propagate maps for a single evsel Adrian Hunter
2015-09-16 7:34 ` [tip:perf/core] perf evlist: " tip-bot for Adrian Hunter
2015-09-08 7:58 ` [PATCH V3 11/14] perf tools: Fix perf_evlist__add() not propagating maps Adrian Hunter
2015-09-15 14:18 ` Arnaldo Carvalho de Melo
2015-09-16 7:34 ` [tip:perf/core] perf evlist: Fix add() " tip-bot for Adrian Hunter
2015-09-08 7:59 ` [PATCH V3 12/14] perf tools: Fix perf_evlist__create_syswide_maps() " Adrian Hunter
2015-09-16 7:34 ` [tip:perf/core] perf evlist: Fix create_syswide_maps() " tip-bot for Adrian Hunter
2015-09-08 7:59 ` [PATCH V3 13/14] perf tools: Fix task exit test setting maps Adrian Hunter
2015-09-16 7:35 ` [tip:perf/core] perf tests: " tip-bot for Adrian Hunter
2015-09-08 7:59 ` [PATCH V3 14/14] perf tools: Fix software clock events " Adrian Hunter
2015-09-16 7:35 ` [tip:perf/core] perf tests: " tip-bot for Adrian Hunter
2015-09-08 8:08 ` [PATCH V3 00/14] perf tools: Fix gaps propagating maps Jiri Olsa
2015-09-15 6:52 ` Adrian Hunter
2015-09-15 13:06 ` Arnaldo Carvalho de Melo [this message]
2015-09-15 14:17 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150915130619.GA2346@redhat.com \
--to=acme@redhat.com \
--cc=adrian.hunter@intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.