From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC
Date: Wed, 16 Sep 2015 00:48:19 +0200 [thread overview]
Message-ID: <201509160048.19315.marex@denx.de> (raw)
In-Reply-To: <55F89245.5040500@opensource.altera.com>
On Tuesday, September 15, 2015 at 11:48:53 PM, Dinh Nguyen wrote:
> On 09/15/2015 03:22 PM, Marek Vasut wrote:
> > On Tuesday, September 15, 2015 at 09:47:23 PM,
> > dinguyen at opensource.altera.com
> >
> > wrote:
> >> From: Dinh Nguyen <dinguyen@opensource.altera.com>
> >>
> >> Enable the able to save the environment variables when SD/MMC is used.
> >>
> >> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> >
> > Hi,
> >
> > this should be done per-board, so I'd suggest the following:
> > 1) Rename include/configs/socfpga_cyclone5.h to socfpga_cyclone5_socdk.h
> >
> > (to make it in-line with the naming in boards/altera/ , sorry, I
> > forgot
> >
> > about this bit :( You'd also have to fix the MAINTAINERS file to
> > match the adjusted filename).
> >
> > 2) Rename socfpga_arria5.h to socfpga_arria5_socdk.h
> > 3) Enable this for both boards in socfpga_*_socdk.h
> >
> > Can you do that please ?
>
> Yes, I can do that.
Thanks!
btw when doing the rename of the files, use git format-patch -M -C ,
this will only mark the move in the patch, without doing the removal
and insertion of a file, so the diff will be shorter while retaining
all the information.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-09-15 22:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 19:47 [U-Boot] [PATCH] ARM: socfpga: Enable saveenv for SD/MMC dinguyen at opensource.altera.com
2015-09-15 20:22 ` Marek Vasut
2015-09-15 21:48 ` Dinh Nguyen
2015-09-15 22:48 ` Marek Vasut [this message]
2015-09-16 6:57 ` Pavel Machek
2015-09-16 6:59 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201509160048.19315.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.