All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sascha Hauer <s.hauer@pengutronix.de>
To: Antony Pavlov <antonynpavlov@gmail.com>
Cc: barebox@lists.infradead.org, Kevin Du Huanpeng <u74147@gmail.com>
Subject: Re: [PATCH] MIPS: start.S depends on banner
Date: Wed, 16 Sep 2015 10:35:23 +0200	[thread overview]
Message-ID: <20150916083523.GE4018@pengutronix.de> (raw)
In-Reply-To: <20150916105033.d6d9a93ef5344d0c12ad4334@gmail.com>

On Wed, Sep 16, 2015 at 10:50:33AM +0300, Antony Pavlov wrote:
> On Wed, 16 Sep 2015 14:40:48 +0800
> Kevin Du Huanpeng <u74147@gmail.com> wrote:
> 
> > Signed-off-by: Kevin Du Huanpeng <u74147@gmail.com>
> > ---
> >  arch/mips/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index aeb5c04..fde4c2e 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -6,6 +6,7 @@ config MIPS
> >  	select HAS_KALLSYMS
> >  	select HAVE_CONFIGURABLE_MEMORY_LAYOUT
> >  	select HAVE_CONFIGURABLE_TEXT_BASE
> > +	select BANNER
> >  	default y
> >  
> >  config SYS_SUPPORTS_BIG_ENDIAN
> > -- 
> > 1.9.1
> > 
> 
> IMHO we can make banner use in start.S optional. E.g.:
> 
> diff --git a/arch/mips/boot/start.S b/arch/mips/boot/start.S
> index 7e2ae5e..f3a6a00 100644
> --- a/arch/mips/boot/start.S
> +++ b/arch/mips/boot/start.S
> @@ -22,8 +22,10 @@
>  #include <asm/mipsregs.h>
>  #include <asm/asm.h>
>  #include <asm-generic/memory_layout.h>
> +#ifdef CONFIG_BANNER
>  #include <generated/compile.h>
>  #include <generated/utsrelease.h>
> +#endif

CONFIG_BANNER and this compilation failure have nothing to do with each
other.

The problem we have is that start.S may get compiled before
generated/compile.h is generated. This is because there is no
Make dependency from start.S to generated/compile.h. Look at
common/Makefile. There we have:

$(obj)/version.o: include/generated/compile.h

This makes sure that generated/compile.h is generated before compiling
version.c.

In arch/mips/boot/Makefile we would need:

$(obj)/start.o: include/generated/compile.h

The problem is that we do not have the rule to generate compile.h
available in this Makefile, so we would also need:

       chk_compile.h = :
 quiet_chk_compile.h = echo '  CHK     $@'
silent_chk_compile.h = :
include/generated/compile.h: FORCE
	@$($(quiet)chk_compile.h)
	$(Q)$(CONFIG_SHELL) $(srctree)/scripts/mkcompile_h $@ \
	"$(UTS_MACHINE)" "$(CC) $(KBUILD_CFLAGS)"

in arch/mips/boot/Makefile.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2015-09-16  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  6:40 [PATCH] MIPS: start.S depends on banner Kevin Du Huanpeng
2015-09-16  7:50 ` Antony Pavlov
2015-09-16  7:57   ` Antony Pavlov
2015-09-16  8:35   ` Sascha Hauer [this message]
2015-09-16  9:06     ` Antony Pavlov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150916083523.GE4018@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=antonynpavlov@gmail.com \
    --cc=barebox@lists.infradead.org \
    --cc=u74147@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.