re: NTB: Use unique DMA channels for TX and RX

[Dan Carpenter <dan.carpenter@oracle.com>]

Hello Dave Jiang,

This is a semi-automatic email about new static checker warnings.

The patch 569410ca756c: "NTB: Use unique DMA channels for TX and RX" 
from Jul 13, 2015, leads to the following Smatch complaint:

drivers/ntb/ntb_transport.c:2008 ntb_transport_max_size()
	 error: we previously assumed 'qp->tx_dma_chan' could be null (see line 2005)

drivers/ntb/ntb_transport.c
  2004	
  2005		if (!qp->tx_dma_chan && !qp->rx_dma_chan)

Patch adds new checks for NULL.  Was || intended here perhaps?

  2006			return qp->tx_max_frame - sizeof(struct ntb_payload_header);
  2007	
  2008		copy_align = max(qp->tx_dma_chan->device->copy_align,
  2009				 qp->rx_dma_chan->device->copy_align);

Patch adds unchecked dereferences.

  2010	

regards,
dan carpenter