From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Jan Engelhardt <jengelh@inai.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] build: bump library versioning
Date: Wed, 16 Sep 2015 19:28:36 +0200 [thread overview]
Message-ID: <20150916172836.GA29575@salvia> (raw)
In-Reply-To: <1442423567-12120-1-git-send-email-jengelh@inai.de>
On Wed, Sep 16, 2015 at 07:12:47PM +0200, Jan Engelhardt wrote:
> Commit libnftnl-1.0.3-31-g5ea54b2 removed a symbol. Such requires a
> bumped to n+1:0:0.
Right, nft_rule_expr_build_payload() was gone. But noone was using it
in our tree. But we have to update LIBTOOL version according, yes.
> The symbol groups can be merged again to save time
> processing them as the groups are relative to a particular SONAME
> (of which we have a new one).
>
> Signed-off-by: Jan Engelhardt <jengelh@inai.de>
> ---
> This essentially supersedes "[PATCH libnftnl 0/2] map fixes".
> The use of LIBNFTNL_4 as a symbol name is modeled upon the LIBVERSION
> number. Doing this instead of _x.y is a (more) sensible choice,
> because the next modification to the symbol map (LIBNFTNL_5) needs to
> be accompanied by LIBVERSION=5:0:something in any case.
>
>
> src/libnftnl.map | 14 ++------------
> 1 file changed, 2 insertions(+), 12 deletions(-)
>
> diff --git a/src/libnftnl.map b/src/libnftnl.map
> index 14ec88c..991fe9d 100644
> --- a/src/libnftnl.map
> +++ b/src/libnftnl.map
> @@ -1,4 +1,4 @@
> -LIBNFTNL_1.0 {
> +LIBNFTNL_4 {
This is breaking hard existing nft binaries, which is what I was
trying to avoid.
But I can use LIBNFTNL_4 for the new nftnl_ symbols.
Will send a new patchset round. Thanks.
next prev parent reply other threads:[~2015-09-16 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 17:12 [PATCH] build: bump library versioning Jan Engelhardt
2015-09-16 17:28 ` Pablo Neira Ayuso [this message]
2015-09-16 18:00 ` Pablo Neira Ayuso
2015-09-16 18:22 ` Pablo Neira Ayuso
2015-09-16 18:31 ` Jan Engelhardt
2015-09-16 18:49 ` Pablo Neira Ayuso
2015-09-16 20:40 ` Jan Engelhardt
2015-09-17 11:03 ` Pablo Neira Ayuso
2015-09-16 18:30 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916172836.GA29575@salvia \
--to=pablo@netfilter.org \
--cc=jengelh@inai.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.