From mboxrd@z Thu Jan 1 00:00:00 1970 From: jszhang@marvell.com (Jisheng Zhang) Date: Thu, 17 Sep 2015 01:10:21 +0800 Subject: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") In-Reply-To: <20150917005908.111c00ca@xhacker> References: <20150917003202.498ff83c@xhacker> <20150917005908.111c00ca@xhacker> Message-ID: <20150917011021.0460792d@xhacker> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Dear Thomas, On Thu, 17 Sep 2015 00:59:08 +0800 Jisheng Zhang wrote: > On Wed, 16 Sep 2015 18:52:41 +0200 > Thomas Gleixner wrote: > > > On Thu, 17 Sep 2015, Jisheng Zhang wrote: > > > > > Hi Marc, > > > > > > Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a > > > guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one > > > GIC, the secondary irq controller is Synopsys DW iCtl: > > > drivers/irqchip/irq-dw-apb-ictl.c > > > > > > So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns > > > false. The logic in cascading_gic_irq() doesn't take cascaded irq controller > > > which is provided by non-gic controllers. > > > > I have a fix pending for this in > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq > > > > 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag > > > > Can you please give that a try? > > Sure, Will try and get back to you Good news! The regression is fixed, cascaded irq works again! Feel free to add Tested-by: Jisheng Zhang Thanks lot for this patch, Jisheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752918AbbIPROQ (ORCPT ); Wed, 16 Sep 2015 13:14:16 -0400 Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:33301 "EHLO mx0a-0016f401.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752596AbbIPROO (ORCPT ); Wed, 16 Sep 2015 13:14:14 -0400 Date: Thu, 17 Sep 2015 01:10:21 +0800 From: Jisheng Zhang To: Thomas Gleixner CC: , , , Subject: Re: Regression by 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a guest") Message-ID: <20150917011021.0460792d@xhacker> In-Reply-To: <20150917005908.111c00ca@xhacker> References: <20150917003202.498ff83c@xhacker> <20150917005908.111c00ca@xhacker> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2015-09-16_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=inbound_notspam policy=inbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1507310000 definitions=main-1509160214 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Thomas, On Thu, 17 Sep 2015 00:59:08 +0800 Jisheng Zhang wrote: > On Wed, 16 Sep 2015 18:52:41 +0200 > Thomas Gleixner wrote: > > > On Thu, 17 Sep 2015, Jisheng Zhang wrote: > > > > > Hi Marc, > > > > > > Commit 01f779f4862b ("irqchip/GIC: Don't deactivate interrupts forwarded to a > > > guest") causes a regression on Marvell BG4CT SoC. In this SoC, there's only one > > > GIC, the secondary irq controller is Synopsys DW iCtl: > > > drivers/irqchip/irq-dw-apb-ictl.c > > > > > > So cascading_gic_irq() should return true on Marvell BG4CT SoC, but it returns > > > false. The logic in cascading_gic_irq() doesn't take cascaded irq controller > > > which is provided by non-gic controllers. > > > > I have a fix pending for this in > > > > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git tmp.irq > > > > 714665351cc7: irqchip/gic: Use IRQD_FORWARDED_TO_VCPU flag > > > > Can you please give that a try? > > Sure, Will try and get back to you Good news! The regression is fixed, cascaded irq works again! Feel free to add Tested-by: Jisheng Zhang Thanks lot for this patch, Jisheng