diff for duplicates of <20150917051644.GA6665@amd> diff --git a/a/1.txt b/N1/1.txt index a4c0030..4fc7a7b 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ -> > if (image->depth = 1) { -> > if (p->fix.visual = FB_VISUAL_TRUECOLOR || -> > p->fix.visual = FB_VISUAL_DIRECTCOLOR) { +> > if (image->depth == 1) { +> > if (p->fix.visual == FB_VISUAL_TRUECOLOR || +> > p->fix.visual == FB_VISUAL_DIRECTCOLOR) { > > fgcolor = ((u32*)(p->pseudo_palette))[image->fg_color]; > > bgcolor = ((u32*)(p->pseudo_palette))[image->bg_color]; > > } else { @@ -9,8 +9,8 @@ > > bgcolor = image->bg_color; > > } > > -> > if (32 % bpp = 0 && !start_index && !pitch_index && -> > ((width & (32/bpp-1)) = 0) && +> > if (32 % bpp == 0 && !start_index && !pitch_index && +> > ((width & (32/bpp-1)) == 0) && > > bpp >= 8 && bpp <= 32) > > fast_imageblit(image, p, dst1, fgcolor, bgcolor); > > else @@ -20,7 +20,7 @@ > > color_imageblit(image, p, dst1, start_index, pitch_i > > > > -> > Notice that bpp is not checked for zero, and thus bpp=0 is totally +> > Notice that bpp is not checked for zero, and thus bpp==0 is totally > > feasible? resulting in 32/bpp crashing the kernel? > > > @@ -30,7 +30,7 @@ > And is there some way to force kernel to dump backtrace into dmesg when > division by zero occur? -You can do WARN_ON(bpp=1) ... and should probably return in that +You can do WARN_ON(bpp==1) ... and should probably return in that case. Pavel diff --git a/a/content_digest b/N1/content_digest index 87855fd..e9e2ae8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\020150819081139.GB15712@pali\0" "From\0Pavel Machek <pavel@ucw.cz>\0" "Subject\0Re: omapdss: Division by zero in kernel\0" - "Date\0Thu, 17 Sep 2015 05:16:44 +0000\0" + "Date\0Thu, 17 Sep 2015 07:16:44 +0200\0" "To\0Pali Roh\303\241r <pali.rohar@gmail.com>\0" "Cc\0Peter Teoh <htmldeveloper@gmail.com>" Tomi Valkeinen <tomi.valkeinen@ti.com> @@ -19,9 +19,9 @@ "\00:1\0" "b\0" "\n" - "> > if (image->depth = 1) {\n" - "> > if (p->fix.visual = FB_VISUAL_TRUECOLOR ||\n" - "> > p->fix.visual = FB_VISUAL_DIRECTCOLOR) {\n" + "> > if (image->depth == 1) {\n" + "> > if (p->fix.visual == FB_VISUAL_TRUECOLOR ||\n" + "> > p->fix.visual == FB_VISUAL_DIRECTCOLOR) {\n" "> > fgcolor = ((u32*)(p->pseudo_palette))[image->fg_color];\n" "> > bgcolor = ((u32*)(p->pseudo_palette))[image->bg_color];\n" "> > } else {\n" @@ -29,8 +29,8 @@ "> > bgcolor = image->bg_color;\n" "> > }\n" "> > \n" - "> > if (32 % bpp = 0 && !start_index && !pitch_index &&\n" - "> > ((width & (32/bpp-1)) = 0) &&\n" + "> > if (32 % bpp == 0 && !start_index && !pitch_index &&\n" + "> > ((width & (32/bpp-1)) == 0) &&\n" "> > bpp >= 8 && bpp <= 32)\n" "> > fast_imageblit(image, p, dst1, fgcolor, bgcolor);\n" "> > else\n" @@ -40,7 +40,7 @@ "> > color_imageblit(image, p, dst1, start_index, pitch_i\n" "> > \n" "> > \n" - "> > Notice that bpp is not checked for zero, and thus bpp=0 is totally\n" + "> > Notice that bpp is not checked for zero, and thus bpp==0 is totally\n" "> > feasible? resulting in 32/bpp crashing the kernel?\n" "> > \n" "> \n" @@ -50,7 +50,7 @@ "> And is there some way to force kernel to dump backtrace into dmesg when\n" "> division by zero occur?\n" "\n" - "You can do WARN_ON(bpp=1) ... and should probably return in that\n" + "You can do WARN_ON(bpp==1) ... and should probably return in that\n" "case.\n" "\n" "\t\t\t\t\t\t\t\tPavel\n" @@ -58,4 +58,4 @@ "(english) http://www.livejournal.com/~pavelmachek\n" (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -418e6be60dc3b0646f9e563b9e6b71ad744b73a5c2de0e951ba2c00830a62be6 +cc1ced440da1044a72f33b8fefaf288ce645646826b1fee1556049da206fd28c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.