From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudip Mukherjee Subject: Re: [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice Date: Thu, 17 Sep 2015 16:47:40 +0530 Message-ID: <20150917111740.GD20514@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> <55F6E68D.8070800@codeaurora.org> <20150916094648.GA11711@gmail.com> <20150917083442.GA24766@gmail.com> <55FA9BDD.7010603@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id A25F26E0DE for ; Thu, 17 Sep 2015 04:17:50 -0700 (PDT) Received: by padhy16 with SMTP id hy16so18003681pad.1 for ; Thu, 17 Sep 2015 04:17:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55FA9BDD.7010603@codeaurora.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Archit Taneja Cc: Daniel Vetter , LKML , dri-devel , Archit Taneja , Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBTZXAgMTcsIDIwMTUgYXQgMDQ6MjQ6MjFQTSArMDUzMCwgQXJjaGl0IFRhbmVqYSB3 cm90ZToKPiAKPiAKPiBPbiA5LzE3LzIwMTUgMjowNCBQTSwgSW5nbyBNb2xuYXIgd3JvdGU6Cj4g Pgo+ID4KPiA+KiBJbmdvIE1vbG5hciA8bWluZ29Aa2VybmVsLm9yZz4gd3JvdGU6Cj4gPgo+ID4K PiA+Cj4gPj5TbyB0aGlzIHBhdGNoIHdhcyB3aGl0ZXNwYWNlIGRhbWFnZWQgLSBJIGFwcGxpZWQg aXQgYnkgaGFuZCBhbmQgbWFkZSB0aGUgY29tbWl0Cj4gPgo+ID4+YmVsb3cuIFRoaXMgaGFzIHNv bHZlZCB0aGUgY3Jhc2gsIHRoYW5rcyBBcmNoaXQhCj4gPgo+ID4KPiA+Cj4gPlNwb2tlIHRvbyBz b29uIC0gdGhlIGF0dGFjaGVkIChhbGx5ZXNjb25maWctaXNoKSBjb25maWcgc3RpbGwgY3Jhc2hl cywgZmlyc3QgdGhlcmUKPiA+Cj4gPmFyZSBhIGhhbmRmdWwgb2Yga29iamVjdCBkZWJ1ZyB3YXJu aW5ncywgdGhlbjoKPiAKPiBUaGUgZXJyb3IgaGFuZGxpbmcgaW4gdGhlIGRyaXZlciBpcyBiYWQu IFRoZSBtYWluIHByb2JsZW0gaXMgdGhhdAo+IHRoZSBkcml2ZXJfbG9hZCBvcCBjYWxscyBtZ2Fn MjAwX2RyaXZlcl91bmxvYWQgaWYgYW55dGhpbmcgZmFpbHMsCj4gd2hpY2ggZG9lc24ndCB3b3Jr IHdlbGwgaWYgZHJpdmVyX2xvYWQgZmFpbHMgbWlkIHdheS4KbWdhZzIwMF9kcml2ZXJfdW5sb2Fk IGlzIHRyeWluZyB0byB1bmxvYWQgZXZlcnl0aGluZyBldmVuaWYgdGhhdCBoYXMgbm90CnN1Y2Nl ZWRlZCBpbiBpbml0aWFsaXppbmcuIEhlcmUgdGhlIHR0bSBmYWlsZWQgdG8gaW5pdGlhbGl6ZSBi dXQKc3RpbGwgbWdhZzIwMF9tbV9maW5pIHdhcyBjYWxsZWQgdG8gdW5sb2FkIGl0LgoKcmVnYXJk cwpzdWRpcApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpk cmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751714AbbIQLRw (ORCPT ); Thu, 17 Sep 2015 07:17:52 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:36297 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbIQLRu (ORCPT ); Thu, 17 Sep 2015 07:17:50 -0400 Date: Thu, 17 Sep 2015 16:47:40 +0530 From: Sudip Mukherjee To: Archit Taneja Cc: Ingo Molnar , Daniel Vetter , Dave Airlie , David Airlie , LKML , dri-devel , Archit Taneja Subject: Re: [PATCH] drm/mgag200: Fix calling drm_fb_helper_fini() twice Message-ID: <20150917111740.GD20514@sudip-pc> References: <1441627110-13783-1-git-send-email-sudipm.mukherjee@gmail.com> <20150913093607.GA6074@gmail.com> <55F6E68D.8070800@codeaurora.org> <20150916094648.GA11711@gmail.com> <20150917083442.GA24766@gmail.com> <55FA9BDD.7010603@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55FA9BDD.7010603@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 04:24:21PM +0530, Archit Taneja wrote: > > > On 9/17/2015 2:04 PM, Ingo Molnar wrote: > > > > > >* Ingo Molnar wrote: > > > > > > > >>So this patch was whitespace damaged - I applied it by hand and made the commit > > > >>below. This has solved the crash, thanks Archit! > > > > > > > >Spoke too soon - the attached (allyesconfig-ish) config still crashes, first there > > > >are a handful of kobject debug warnings, then: > > The error handling in the driver is bad. The main problem is that > the driver_load op calls mgag200_driver_unload if anything fails, > which doesn't work well if driver_load fails mid way. mgag200_driver_unload is trying to unload everything evenif that has not succeeded in initializing. Here the ttm failed to initialize but still mgag200_mm_fini was called to unload it. regards sudip