From: Simon Guinot <simon.guinot@sequanux.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: mvebu: timer.c: Explicitly move "init_done" var to data section
Date: Thu, 17 Sep 2015 13:25:54 +0200 [thread overview]
Message-ID: <20150917112554.GL7306@kw.sim.vm.gnt> (raw)
In-Reply-To: <1441277227-1656-1-git-send-email-sr@denx.de>
On Thu, Sep 03, 2015 at 12:47:07PM +0200, Stefan Roese wrote:
> As reported by Simon Guinot, commit ade741b3
> "arm: mvebu: Call timer_init early before PHY and DDR init" breaks
> Kirkwood platforms. As the static variable "init_done" is not
> available at that early boot time. This patch moves it to explicitly
> to the data section, making it available at that time.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Reported-by: Simon Guinot <simon.guinot@sequanux.org>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
Tested-by: Simon Guinot <simon.guinot@sequanux.org>
Thanks,
Simon
> ---
> arch/arm/mach-mvebu/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-mvebu/timer.c b/arch/arm/mach-mvebu/timer.c
> index c516c41..5449a89 100644
> --- a/arch/arm/mach-mvebu/timer.c
> +++ b/arch/arm/mach-mvebu/timer.c
> @@ -41,7 +41,7 @@
> #define timestamp gd->arch.tbl
> #define lastdec gd->arch.lastinc
>
> -static int init_done;
> +static int init_done __attribute__((section(".data"))) = 0;
>
> /* Timer reload and current value registers */
> struct kwtmr_val {
> --
> 2.5.1
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150917/a3f5697b/attachment.sig>
prev parent reply other threads:[~2015-09-17 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 10:47 [U-Boot] [PATCH] arm: mvebu: timer.c: Explicitly move "init_done" var to data section Stefan Roese
2015-09-17 11:25 ` Simon Guinot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917112554.GL7306@kw.sim.vm.gnt \
--to=simon.guinot@sequanux.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.