All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Josh Boyer" <jwboyer@fedoraproject.org>,
	"Philip Müller" <philm@manjaro.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
	"Sudeep Holla" <sudeep.holla@arm.com>,
	"Guenter Roeck" <linux@roeck-us.net>,
	manjaro-dev@manjaro.org, "Ingo Molnar" <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Andre Przywara" <andre.przywara@arm.com>,
	"Borislav Petkov" <bp@suse.de>
Subject: Re: [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686
Date: Thu, 17 Sep 2015 05:54:04 -0700	[thread overview]
Message-ID: <20150917125404.GC16085@kroah.com> (raw)
In-Reply-To: <20150917071504.GA12316@nazgul.tnic>

On Thu, Sep 17, 2015 at 09:15:04AM +0200, Borislav Petkov wrote:
> On Wed, Sep 16, 2015 at 07:52:47PM -0400, Josh Boyer wrote:
> > On Sun, Jul 26, 2015 at 10:42 AM, Borislav Petkov <bp@alien8.de> wrote:
> > > On Sun, Jul 26, 2015 at 12:54:55PM +0200, Philip Müller wrote:
> > >> I can confirm your patch working. However, it might be good to use yours
> > >> and Thomas' in combination to solve this properly.
> > >
> > > Please do not top-post.
> > >
> > > We could use Thomas' too although from looking at it,
> > > detect_cache_attributes() allocates a per-CPU per_cpu_cacheinfo thing
> > > for each CPU. By the time we hit cache_shared_cpu_map_remove() in
> > > free_cache_attributes(), those per_cpu_cacheinfo(cpu) things are still
> > > allocated. We kfree them in the next step only.
> > >
> > > But I like the moving of the check from the CPU hotplug callback to
> > > free_cache_attributes().
> > >
> > > So I'll merge the two patches and write up a proper commit message,
> > > unless someone objects.
> > >
> > > I'll add your Tested-by too.
> > 
> > Did this actually happen?  I don't see either fix in Linus' tree yet,
> > the merge window is closed, and the bug happens on 4.1 and 4.2 stable
> > kernels..
> 
> Greg wanted to pick it up...
> 
> Greg, what's up?

It's in my "to-apply" queue, let me go dig it up now...

thanks for the reminder.

greg k-h

  reply	other threads:[~2015-09-17 12:54 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 22:23 [linux41] Kernel panic at i686 Philip Müller
2015-07-26  6:18 ` [linux41] regression with 'x86/cacheinfo: Move cacheinfo sysfs code to generic infrastructure' on AMD i686 Philip Müller
2015-07-26  8:13   ` Thomas Gleixner
2015-07-26  8:41     ` Borislav Petkov
2015-07-26 10:54       ` Philip Müller
2015-07-26 14:42         ` Borislav Petkov
2015-07-26 15:59           ` Philip Müller
2015-07-26 16:11             ` Guenter Roeck
2015-09-16 23:52           ` Josh Boyer
2015-09-17  5:36             ` Philip Müller
2015-09-17  7:15             ` Borislav Petkov
2015-09-17 12:54               ` Greg KH [this message]
2015-07-27  7:58   ` [PATCH] cpu/cacheinfo: Fix teardown path Borislav Petkov
2015-07-27  8:56     ` Sudeep Holla
2015-07-27 11:10     ` Thomas Gleixner
2015-07-27 18:49       ` Philip Müller
2015-08-05 20:14     ` [tip:x86/urgent] x86/cpu/cacheinfo: " tip-bot for Borislav Petkov
2015-08-08  8:46     ` [PATCH] cpu/cacheinfo: " Borislav Petkov
2015-08-08 15:41       ` Greg KH
2015-08-08 18:23         ` Philip Müller
2015-08-08 19:42           ` Borislav Petkov
2015-08-08 19:47         ` Borislav Petkov
2015-09-13  7:03           ` Philip Müller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917125404.GC16085@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andre.przywara@arm.com \
    --cc=bp@alien8.de \
    --cc=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=manjaro-dev@manjaro.org \
    --cc=mingo@redhat.com \
    --cc=philm@manjaro.org \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.