From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH v4] platform:x86: add Intel P-Unit mailbox IPC driver Date: Thu, 17 Sep 2015 10:45:04 -0700 Message-ID: <20150917174504.GA12959@vmdeb7> References: <1441708182-66875-1-git-send-email-qipeng.zha@intel.com> <40786695AB8ED34B85C0BFEA910C834433C576F1@IRSMSX103.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:58604 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751979AbbIQRpH (ORCPT ); Thu, 17 Sep 2015 13:45:07 -0400 Content-Disposition: inline In-Reply-To: Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: "Zha, Qipeng" Cc: "Shevchenko, Andriy" , "platform-driver-x86@vger.kernel.org" , "Westerberg, Mika" On Mon, Sep 14, 2015 at 02:42:53AM +0000, Zha, Qipeng wrote: > >> + > >> +/* Some modules are dependent on this, so init earlier */ > >> +fs_initcall(intel_punit_ipc_init); > > >So, what exactly requires this? > Those drivers which need to use this Punit APIs in its Probe when do module init. As you know, cross driver calls is something we work to avoid specifically for the issues of load order, etc. As this is a new driver, there shouldn't be in users of this currently. Is it expected there will be in the near future? -- Darren Hart Intel Open Source Technology Center