From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: mark.rutland@arm.com, Shengjiu Wang <shengjiu.wang@freescale.com>,
pawel.moll@arm.com, ijc+devicetree@hellion.org.uk,
Xiubo.Lee@gmail.com, timur@tabi.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, robh+dt@kernel.org,
galak@codeaurora.org, tiwai@suse.com
Subject: Re: [PATCH V1 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device
Date: Thu, 17 Sep 2015 10:54:08 -0700 [thread overview]
Message-ID: <20150917175407.GA2544@Asurada-CZ80> (raw)
In-Reply-To: <20150917110154.GC12027@sirena.org.uk>
On Thu, Sep 17, 2015 at 12:01:54PM +0100, Mark Brown wrote:
> On Thu, Sep 17, 2015 at 02:09:24PM +0800, Shengjiu Wang wrote:
>
> > + "dma" The spba clock is needed when sdma share peripheral
> > + script is used.
> It sounds like this clock is used by the DMA controller - shouldn't the
> DMA controller driver be responsible for enabling it?
I agree but it doesn't seems to be easy to enable and disable it
dynamically along with ASoC open() and close() functions as the
current clocks of SDMA get enabled when its channels are allocated
during the system boot-up via generic DMA bindings.
Maybe we can put in the issue_pending() and terminate_all() which
are regularly called along with ASoC trigger(), or just open it
permanently if the penalty of power efficiency is ignorable.
next prev parent reply other threads:[~2015-09-17 17:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 6:09 [PATCH V1 0/3] fsl esai/spdif/asrc need spba clock Shengjiu Wang
2015-09-17 6:09 ` [PATCH V1 1/3] ASoC: fsl_esai: spba clock is needed by esai device Shengjiu Wang
2015-09-17 6:50 ` Nicolin Chen
2015-09-17 6:09 ` [PATCH V1 2/3] ASoC: fsl_spdif: spba clk is needed by spdif device Shengjiu Wang
2015-09-17 11:01 ` Mark Brown
2015-09-17 17:54 ` Nicolin Chen [this message]
2015-09-19 13:50 ` Mark Brown
2015-10-10 10:26 ` Shengjiu Wang
2015-10-10 20:03 ` Fabio Estevam
2015-10-10 20:35 ` Nicolin Chen
2015-11-04 8:34 ` Shengjiu Wang
2015-11-04 17:31 ` Nicolin Chen
2015-09-17 6:09 ` [PATCH V1 3/3] ASoC: fsl_asrc: spba clock is needed by asrc device Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917175407.GA2544@Asurada-CZ80 \
--to=nicoleotsuka@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@freescale.com \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.