From: Remi Pommarel <repk@triplefau.lt>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>,
Jeff King <peff@peff.net>, Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] Makefile: Change library order for static linking
Date: Thu, 17 Sep 2015 23:20:16 +0200 [thread overview]
Message-ID: <20150917212016.GF606@cruxbox> (raw)
In-Reply-To: <xmqqfv2cj03t.fsf@gitster.mtv.corp.google.com>
On Thu, Sep 17, 2015 at 12:51:18PM -0700, Junio C Hamano wrote:
> IIRC historically the division between ssl and crypto was messy.
> Especially, I am not sure if the change to NEEDS_SSL_WITH_CRYPTO
> in this patch is correct for platforms that require that macro
> defined.
I think it is correct as anywhere else in Makefile the order is ssl
first then crypto (from Makefile:1047):
ifdef NEEDS_SSL_WITH_CURL
CURL_LIBCURL += -lssl
ifdef NEEDS_CRYPTO_WITH_SSL
CURL_LIBCURL += -lcrypto
endif
endif
>
> Other changes in this patch looks sensible, though.
If you agree with the NEED_SSL_WITH_CURL modification, I'll resend a
patch with the typos corrected.
next prev parent reply other threads:[~2015-09-17 21:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 21:12 [PATCH] Makefile: Change library order for static linking Remi Pommarel
2015-09-17 19:25 ` Eric Sunshine
2015-09-17 21:31 ` Remi Pommarel
2015-09-17 19:51 ` Junio C Hamano
2015-09-17 21:20 ` Remi Pommarel [this message]
2015-09-17 22:08 ` Junio C Hamano
2015-09-18 7:17 ` Remi Pommarel
2015-09-21 17:09 ` Junio C Hamano
2015-09-22 20:37 ` Remi Pommarel
2015-09-22 21:30 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150917212016.GF606@cruxbox \
--to=repk@triplefau.lt \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.