From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH] IB/ucma: check workqueue allocation before usage Date: Thu, 17 Sep 2015 16:59:34 -0600 Message-ID: <20150917225934.GA22326@obsidianresearch.com> References: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1442520259-2248-1-git-send-email-sasha.levin-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yishai Hadas Cc: Sasha Levin , dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On Thu, Sep 17, 2015 at 04:04:19PM -0400, Sasha Levin wrote: > Allocating a workqueue might fail, which wasn't checked so far and would > lead to NULL ptr derefs when an attempt to use it was made. Indeed. Yishai, please check this and check the other patches you've sent to see if they have a similar error. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752053AbbIQW7y (ORCPT ); Thu, 17 Sep 2015 18:59:54 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:40187 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751604AbbIQW7x (ORCPT ); Thu, 17 Sep 2015 18:59:53 -0400 Date: Thu, 17 Sep 2015 16:59:34 -0600 From: Jason Gunthorpe To: Yishai Hadas Cc: Sasha Levin , dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] IB/ucma: check workqueue allocation before usage Message-ID: <20150917225934.GA22326@obsidianresearch.com> References: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1442520259-2248-1-git-send-email-sasha.levin@oracle.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 17, 2015 at 04:04:19PM -0400, Sasha Levin wrote: > Allocating a workqueue might fail, which wasn't checked so far and would > lead to NULL ptr derefs when an attempt to use it was made. Indeed. Yishai, please check this and check the other patches you've sent to see if they have a similar error. Jason