All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] sysvinit-2.88 build is failing for ARM64
Date: Thu, 17 Sep 2015 23:07:53 +0200	[thread overview]
Message-ID: <20150917230753.2ad46e4c@free-electrons.com> (raw)
In-Reply-To: <20150917111217.GP11632@tarshish>

Baruch, Joao,

On Thu, 17 Sep 2015 14:12:17 +0300, Baruch Siach wrote:

> On Thu, Sep 17, 2015 at 11:55:32AM +0100, Joao Pinto wrote:
> > The library is checked as:
> > ifneq ($(wildcard $(SYSROOT)/usr/lib*/libcrypt.a),)
> > 
> > And the library is located at:
> > output/host/usr/aarch64-buildroot-linux-gnu/sysroot/usr/lib/aarch64-linux-gnu/libcrypt.a
> > 
> > Maybe for ARM64 we have to make an extra check?
> 
> This check is from package/sysvinit/0001-fix-libcrypt-test.patch. You'll 
> probably need to adjust that patch to match this Linaro toolchain.

In fact, this path-based check is really crappy. I believe it's a lot
better to ask gcc directly:

HAS_LIBCRYPT=$(shell f=`mktemp` && echo 'int main(void) {}' | $(CC) -o $$f -xc - -lcrypt >/dev/null 2>&1 && echo y && rm -f $$f)
ifeq ($(HAS_LIBCRYPT),y)
SULOGINLIBS += -lcrypt
endif

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-09-17 21:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:40 [Buildroot] [PATCH v2] mplayer: enable building on ARM64 jpinto
2015-09-17 10:28 ` [Buildroot] sysvinit-2.88 build is failing for ARM64 Joao Pinto
2015-09-17 10:35   ` Baruch Siach
2015-09-17 10:39     ` Joao Pinto
2015-09-17 10:55       ` Joao Pinto
2015-09-17 11:12         ` Baruch Siach
2015-09-17 11:13           ` Joao Pinto
2015-09-17 21:07           ` Thomas Petazzoni [this message]
2015-09-17 21:39             ` Baruch Siach
2015-09-18  7:26               ` Thomas Petazzoni
2015-09-19 19:34                 ` Baruch Siach
2015-09-17 21:31 ` [Buildroot] [PATCH v2] mplayer: enable building on ARM64 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150917230753.2ad46e4c@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.