All of lore.kernel.org
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: "Zha, Qipeng" <qipeng.zha@intel.com>
Cc: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"Westerberg, Mika" <mika.westerberg@intel.com>
Subject: Re: [PATCH v4] platform:x86: add Intel P-Unit mailbox IPC driver
Date: Thu, 17 Sep 2015 19:43:38 -0700	[thread overview]
Message-ID: <20150918024338.GA66179@vmdeb7> (raw)
In-Reply-To: <C6287702A945AC47BE5DB5DFD4B5C6DD019678BE@SHSMSX104.ccr.corp.intel.com>

On Fri, Sep 18, 2015 at 01:29:11AM +0000, Zha, Qipeng wrote:
> >> >> +/* Some modules are dependent on this, so init earlier */ 
> >> >> +fs_initcall(intel_punit_ipc_init);
> >> 
> >> >So, what exactly requires this?
> >> Those drivers which need to use this Punit APIs in its Probe when do module init.
> 
> >As you know, cross driver calls is something we work to avoid specifically for the issues of load order, etc. As this is a new driver, there shouldn't be in users of this currently. Is it expected there will be in the near future?
> 
> No users currently,  Telemetry driver will use Punit APIs.
> So you suggest don't support Punit calls for other modules in init stage ?

I just saw the Telemetry driver today hit the list, so we have a user. No
objection. That patch series had some issues, so I'm waiting for a v2 which I
can apply and review properly.

Both of these are 4.4 candidates and I'd like them in next for as long as
possible, so please watch for Andriy's upcoming review. Thanks for sticking with
it.

-- 
Darren Hart
Intel Open Source Technology Center

  reply	other threads:[~2015-09-18  2:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-08 10:29 [PATCH v4] platform:x86: add Intel P-Unit mailbox IPC driver Qipeng Zha
2015-09-08 10:42 ` Shevchenko, Andriy
2015-09-14  2:42   ` Zha, Qipeng
2015-09-17 17:45     ` Darren Hart
2015-09-18  1:29       ` Zha, Qipeng
2015-09-18  2:43         ` Darren Hart [this message]
2015-10-08  3:16     ` Zha, Qipeng
2015-10-08 12:18       ` Shevchenko, Andriy
2015-10-08 16:09       ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150918024338.GA66179@vmdeb7 \
    --to=dvhart@infradead.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=mika.westerberg@intel.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qipeng.zha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.