From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tim Deegan <tim@xen.org>
Subject: Re: [PATCH v2] MAINTAINERS: Document maintainers for
	xen/common/
Date: Fri, 18 Sep 2015 11:13:51 +0100
Message-ID: <20150918101351.GA56530@deinos.phlegethon.org>
References: <1442490839-23962-1-git-send-email-ian.jackson@eu.citrix.com>
	<20150917122316.GA43280@deinos.phlegethon.org>
	<22011.68.956821.565239@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Content-Disposition: inline
In-Reply-To: <22011.68.956821.565239@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Julien Grall <julien.grall@citrix.com>, David Vrabel <david.vrabel@citrix.com>, Jan Beulich <jbeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

At 19:02 +0100 on 17 Sep (1442516564), Ian Jackson wrote:
> Tim Deegan writes ("Re: [PATCH v2] MAINTAINERS: Document maintainers for xen/common/"):
> > I would rather your v1 plus an appropriate change to get_maintainers.
> 
> I am happy to implement in get_maintainers whatever is decided.
> 
> At the moment there is one kind of fallback:
> 
> (i) `THE REST' gets CCd iff no file pointed to any other maintainer
> 
> What you may be proposing is a subtly different kind of fallback:
> 
> (ii) `REST OF THE HYPERVISOR' gets CCd iff the patch touches any files
>    in xen/ which do not have another maintainer

Right, I see.  Yes, that is what I was proposing, though thinking
about it I'm not so sure any more.  There seem to be three
possibilities -- filter everything per-file:

 for each file touched:
     M := 'normal' maintainers
     if M is empty and the file is in xen/, M := REST OF HYPERVISOR
     if M is empty, M := THE REST
     CCLIST += M

Filter xen/ per-file but leave THE REST as it is now:

 for each file touched:
     M := 'normal' maintainers
     if M is empty and the file is in xen/, M := REST OF HYPERVISOR
     CCLIST += M
 if CCLIST is empty, CCLIST := THE REST

or only use the fallbacks if nothing in the patch has a real
maintainer: 

 for each file touched:
     CCLIST += 'normal' maintainers
 if CCLIST is empty and any file is in xen/, CCLIST := REST OF HYPERVISOR
 if CCLIST is empty, CCLIST := THE REST

There's a tradeoff between how noisy it gets for the fallback
maintainers and wanting to make sure that someone relevant is always
CC'd.

I think on balance we can rely on the maintainers to ask for second
opinions if they find a patch that touches a lot of common code,
i.e. I prefer the third option.

Cheers,

Tim.