From: Oleg Nesterov <oleg@redhat.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Dmitry Vyukov <dvyukov@google.com>,
ebiederm@xmission.com, Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
mhocko@suse.cz, LKML <linux-kernel@vger.kernel.org>,
ktsan@googlegroups.com, Kostya Serebryany <kcc@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Alexander Potapenko <glider@google.com>,
Hans Boehm <hboehm@google.com>
Subject: Re: [PATCH] kernel: fix data race in put_pid
Date: Fri, 18 Sep 2015 15:31:34 +0200 [thread overview]
Message-ID: <20150918133134.GB10241@redhat.com> (raw)
In-Reply-To: <20150918132844.GA10241@redhat.com>
Damn, sorry for noise,
On 09/18, Oleg Nesterov wrote:
>
> Now. In theory this this code is wrong:
>
> if (Y) {
> BUG_ON(X == 0);
> }
Of course without READ_ONCE() or barrier() in between this code
is buggy in any case. But I hope you understand what I tried to
say...
Oleg.
next prev parent reply other threads:[~2015-09-18 13:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 13:24 [PATCH] kernel: fix data race in put_pid Dmitry Vyukov
2015-09-17 16:08 ` Oleg Nesterov
2015-09-17 16:41 ` Dmitry Vyukov
2015-09-17 17:44 ` Oleg Nesterov
2015-09-17 17:57 ` Dmitry Vyukov
2015-09-17 17:59 ` Dmitry Vyukov
2015-09-17 18:09 ` Oleg Nesterov
2015-09-17 18:38 ` Dmitry Vyukov
2015-09-18 8:51 ` Peter Zijlstra
2015-09-18 8:57 ` Peter Zijlstra
2015-09-18 9:27 ` Peter Zijlstra
2015-09-18 12:31 ` James Hogan
2015-09-18 12:34 ` Peter Zijlstra
2015-09-18 15:56 ` Paul E. McKenney
2015-09-18 9:06 ` Dmitry Vyukov
2015-09-18 9:28 ` Will Deacon
2015-09-18 9:33 ` Peter Zijlstra
2015-09-18 11:22 ` Peter Zijlstra
2015-09-18 11:30 ` Will Deacon
2015-09-18 11:50 ` Dmitry Vyukov
2015-09-18 11:56 ` Peter Zijlstra
2015-09-18 12:19 ` Peter Zijlstra
2015-09-18 12:44 ` Will Deacon
2015-09-18 13:10 ` Peter Zijlstra
2015-09-18 13:44 ` Oleg Nesterov
2015-09-18 13:49 ` Peter Zijlstra
2015-09-18 13:53 ` Dmitry Vyukov
2015-09-18 14:41 ` Oleg Nesterov
2015-09-22 8:38 ` Dmitry Vyukov
2015-09-23 8:48 ` [tip:locking/core] atomic: Implement atomic_read_ctrl() tip-bot for Peter Zijlstra
2015-09-18 16:15 ` [PATCH] kernel: fix data race in put_pid Eric Dumazet
2015-09-18 16:20 ` Peter Zijlstra
2015-09-18 15:57 ` Paul E. McKenney
2015-09-18 13:28 ` Oleg Nesterov
2015-09-18 13:31 ` Oleg Nesterov [this message]
2015-09-18 13:46 ` Peter Zijlstra
2015-09-18 15:00 ` Oleg Nesterov
2015-09-18 15:30 ` Oleg Nesterov
2015-09-18 16:00 ` Paul E. McKenney
2015-09-17 17:56 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150918133134.GB10241@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=glider@google.com \
--cc=hboehm@google.com \
--cc=kcc@google.com \
--cc=ktsan@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.